From e9a241e87b42f902d0408704df6bbcd8bf465a46 Mon Sep 17 00:00:00 2001 From: Aaron Merey Date: Mon, 12 Sep 2022 18:57:38 -0400 Subject: [PATCH] objdump: '-S' should trigger search for separate debuginfo. Add with_source_code to the command line options that trigger might_need_separate_debug_info and dump_any_debugging. This helps 'objdump -S' download missing files via debuginfod without the need for specifying extra command line options like '-L'. --- binutils/ChangeLog | 7 +++++++ binutils/objdump.c | 5 +++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/binutils/ChangeLog b/binutils/ChangeLog index 3cac2353e3b..41a2f9cb0c7 100644 --- a/binutils/ChangeLog +++ b/binutils/ChangeLog @@ -1,3 +1,10 @@ +2022-09-12 Aaron Merey + + * objcopy.c (might_need_separate_debug_info): Add with_source_code to + the options that cause this function to return true. + (main.c): Add with_source_code to the options that enable + dump_any_debugging. + 2022-09-09 Nick Clifton PR 29532 diff --git a/binutils/objdump.c b/binutils/objdump.c index d34f269b406..6610906f83e 100644 --- a/binutils/objdump.c +++ b/binutils/objdump.c @@ -5407,7 +5407,7 @@ might_need_separate_debug_info (bool is_mainfile) return true; if (process_links || dump_symtab || dump_debugging - || dump_dwarf_section_info) + || dump_dwarf_section_info || with_source_code) return true; return false; @@ -6114,7 +6114,8 @@ main (int argc, char **argv) dump_any_debugging = (dump_debugging || dump_dwarf_section_info - || process_links); + || process_links + || with_source_code); if (formats_info) exit_status = display_info (); -- 2.30.2