From e9a433bf192ddcadc7e948ef3b4e0ca64f3396e7 Mon Sep 17 00:00:00 2001 From: Tsukasa OI Date: Thu, 6 Oct 2022 06:36:33 +0000 Subject: [PATCH] sim/rl78: Add ATTRIBUTE_PRINTF Clang generates a warning if the format string of a printf-like function is not a literal ("-Wformat-nonliteral"). On the default configuration, it causes a build failure (unless "--disable-werror" is specified). To avoid warnings on the printf-like wrapper, it requires proper __attribute__((format)) and we have ATTRIBUTE_PRINTF macro for this reason. This commit adds ATTRIBUTE_PRINTF to the printf-like functions. --- sim/rl78/trace.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sim/rl78/trace.c b/sim/rl78/trace.c index 669c2b54615..85880774b14 100644 --- a/sim/rl78/trace.c +++ b/sim/rl78/trace.c @@ -92,7 +92,7 @@ compare_symbols (const void *ap, const void *bp) static char opbuf[1000]; -static int +static int ATTRIBUTE_PRINTF (2, 3) op_printf (char *buf, char *fmt, ...) { int ret; @@ -104,7 +104,7 @@ op_printf (char *buf, char *fmt, ...) return ret; } -static int +static int ATTRIBUTE_PRINTF (3, 4) op_styled_printf (char *buf, enum disassembler_style style, char *fmt, ...) { int ret; -- 2.30.2