From e9af4700bc7435e593dd74d4d2e099b3d7c01eb6 Mon Sep 17 00:00:00 2001 From: Nick Clifton Date: Mon, 16 Apr 2018 12:59:37 +0100 Subject: [PATCH] Prevent an illegal memory access via an out of range fixup pointer. PR 23061 * coffgen.c (coff_pointerize_aux): Check for an out of range fixup. --- bfd/ChangeLog | 6 ++++++ bfd/coffgen.c | 6 ++++-- 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index 9f81866b467..3ea3933fa50 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2018-04-16 Nick Clifton + + PR 23061 + * coffgen.c (coff_pointerize_aux): Check for an out of range + fixup. + 2018-04-16 Alan Modra * Makefile.am: Remove arm-epoc-pe support. diff --git a/bfd/coffgen.c b/bfd/coffgen.c index ff445d2d032..b9e48728a2c 100644 --- a/bfd/coffgen.c +++ b/bfd/coffgen.c @@ -835,7 +835,7 @@ coff_mangle_symbols (bfd *bfd_ptr) for (i = 0; i < s->u.syment.n_numaux; i++) { combined_entry_type *a = s + i + 1; - + BFD_ASSERT (! a->is_sym); if (a->fix_tag) { @@ -1547,7 +1547,9 @@ coff_pointerize_aux (bfd *abfd, if ((ISFCN (type) || ISTAG (n_sclass) || n_sclass == C_BLOCK || n_sclass == C_FCN) - && auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.l > 0) + && auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.l > 0 + && auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.l + < (long) obj_raw_syment_count (abfd)) { auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.p = table_base + auxent->u.auxent.x_sym.x_fcnary.x_fcn.x_endndx.l; -- 2.30.2