From ea3d7d1cab4221ab729327bb4d957352c79d05f0 Mon Sep 17 00:00:00 2001 From: Alan Modra Date: Wed, 30 Nov 2016 15:33:07 +1030 Subject: [PATCH] PR20886, looping in ppc64_elf_size_stubs The PR20886 binary is large enough that there are two stub sections servicing .text (which is 88M). It so happens that between one iteration of sizing and the next that one stub section grows while the other shrinks. Since one section is always growing, the loop never terminates. This patch changes the algorithm to not update previous size on shrinking, once we go past a certain number of iterations. PR ld/20886 * elf64-ppc.c (ppc64_elf_size_stubs): Make rawsize max size seen on any pass past STUB_SHRINK_ITER. --- bfd/ChangeLog | 6 ++++++ bfd/elf64-ppc.c | 5 ++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/bfd/ChangeLog b/bfd/ChangeLog index bfacc20fe2b..e804d6ef4b6 100644 --- a/bfd/ChangeLog +++ b/bfd/ChangeLog @@ -1,3 +1,9 @@ +2016-11-30 Alan Modra + + PR ld/20886 + * elf64-ppc.c (ppc64_elf_size_stubs): Make rawsize max size seen + on any pass past STUB_SHRINK_ITER. + 2016-11-28 H.J. Lu * elflink.c (_bfd_elf_fix_symbol_flags): Hide hidden versioned diff --git a/bfd/elf64-ppc.c b/bfd/elf64-ppc.c index d0113035551..5a4bc724cf9 100644 --- a/bfd/elf64-ppc.c +++ b/bfd/elf64-ppc.c @@ -12617,7 +12617,10 @@ ppc64_elf_size_stubs (struct bfd_link_info *info) stub_sec = stub_sec->next) if ((stub_sec->flags & SEC_LINKER_CREATED) == 0) { - stub_sec->rawsize = stub_sec->size; + if (htab->stub_iteration <= STUB_SHRINK_ITER + || stub_sec->rawsize < stub_sec->size) + /* Past STUB_SHRINK_ITER, rawsize is the max size seen. */ + stub_sec->rawsize = stub_sec->size; stub_sec->size = 0; stub_sec->reloc_count = 0; stub_sec->flags &= ~SEC_RELOC; -- 2.30.2