From ea49d40b3e4fe753cc9180bd9bb814b2a8262721 Mon Sep 17 00:00:00 2001 From: Jan Hubicka Date: Wed, 21 Feb 2018 20:05:30 +0100 Subject: [PATCH] re PR c/84229 (A valid code rejected with -flto) PR c/84229 * ipa-cp.c (determine_versionability): Do not version functions caling va_arg_pack. From-SVN: r257877 --- gcc/ChangeLog | 6 ++++++ gcc/ipa-cp.c | 18 ++++++++++++++++++ 2 files changed, 24 insertions(+) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 14326080acd..2bc276eb9f2 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2018-02-21 Jan Hubicka + + PR c/84229 + * ipa-cp.c (determine_versionability): Do not version functions caling + va_arg_pack. + 2018-02-21 Martin Liska PR driver/83193 diff --git a/gcc/ipa-cp.c b/gcc/ipa-cp.c index 4202c999675..182dc498364 100644 --- a/gcc/ipa-cp.c +++ b/gcc/ipa-cp.c @@ -630,6 +630,24 @@ determine_versionability (struct cgraph_node *node, reason = "calls comdat-local function"; } + /* Functions calling BUILT_IN_VA_ARG_PACK and BUILT_IN_VA_ARG_PACK_LEN + works only when inlined. Cloning them may still lead to better code + becuase ipa-cp will not give up on cloning further. If the function is + external this however leads to wrong code becuase we may end up producing + offline copy of the function. */ + if (DECL_EXTERNAL (node->decl)) + for (cgraph_edge *edge = node->callees; !reason && edge; + edge = edge->next_callee) + if (DECL_BUILT_IN (edge->callee->decl) + && DECL_BUILT_IN_CLASS (edge->callee->decl) == BUILT_IN_NORMAL) + { + if (DECL_FUNCTION_CODE (edge->callee->decl) == BUILT_IN_VA_ARG_PACK) + reason = "external function which calls va_arg_pack"; + if (DECL_FUNCTION_CODE (edge->callee->decl) + == BUILT_IN_VA_ARG_PACK_LEN) + reason = "external function which calls va_arg_pack_len"; + } + if (reason && dump_file && !node->alias && !node->thunk.thunk_p) fprintf (dump_file, "Function %s is not versionable, reason: %s.\n", node->dump_name (), reason); -- 2.30.2