From eb291d7013eef64c33826f9cc0006c89adcf4e53 Mon Sep 17 00:00:00 2001 From: Neil Roberts Date: Tue, 24 Nov 2015 17:59:28 +0100 Subject: [PATCH] i965/gen8+: Don't upload the MCS buffer for single-sampled textures For single-sampled textures the MCS buffer is only used to implement fast clears. However the surface always needs to be resolved before being used as a texture anyway so the the MCS buffer doesn't actually achieve anything. This is important for Gen9 because in that case SRGB surfaces are not supported for fast clears and we don't want the hardware to see the MCS buffer in that case. Reviewed-by: Topi Pohjolainen --- src/mesa/drivers/dri/i965/gen8_surface_state.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/gen8_surface_state.c b/src/mesa/drivers/dri/i965/gen8_surface_state.c index b062bf08aaf..904950dfa07 100644 --- a/src/mesa/drivers/dri/i965/gen8_surface_state.c +++ b/src/mesa/drivers/dri/i965/gen8_surface_state.c @@ -225,7 +225,11 @@ gen8_emit_texture_surface_state(struct brw_context *brw, pitch = mt->pitch; } - if (mt->mcs_mt) { + /* The MCS is not uploaded for single-sampled surfaces because the color + * buffer should always have been resolved before it is used as a texture + * so there is no need for it. + */ + if (mt->mcs_mt && mt->num_samples > 1) { aux_mt = mt->mcs_mt; aux_mode = GEN8_SURFACE_AUX_MODE_MCS; -- 2.30.2