From eb73a69a1538e24fcf39f108d22d324ae8cd1d90 Mon Sep 17 00:00:00 2001 From: Richard Guenther Date: Mon, 30 Jan 2006 13:46:30 +0000 Subject: [PATCH] re PR c++/23372 (Temporary aggregate copy not elided when passing parameters by value) 2006-01-30 Richard Guenther PR c++/23372 * gimplify.c (gimplify_target_expr): Handle easy cases without creating a temporary. * gcc.dg/pr23372-1.C: New testcase. From-SVN: r110396 --- gcc/ChangeLog | 6 ++++++ gcc/gimplify.c | 9 +++++++++ gcc/testsuite/ChangeLog | 5 +++++ gcc/testsuite/gcc.dg/pr23372-1.c | 10 ++++++++++ 4 files changed, 30 insertions(+) create mode 100644 gcc/testsuite/gcc.dg/pr23372-1.c diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 99b6f9fb9e3..dcd3684c4f1 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,9 @@ +2006-01-30 Richard Guenther + + PR c++/23372 + * gimplify.c (gimplify_target_expr): Handle easy cases + without creating a temporary. + 2006-01-30 Nathan Sidwell * vec.h (safe_grow): Remove duplicated line. diff --git a/gcc/gimplify.c b/gcc/gimplify.c index cb1b95eebaa..876160955f5 100644 --- a/gcc/gimplify.c +++ b/gcc/gimplify.c @@ -4053,6 +4053,15 @@ gimplify_target_expr (tree *expr_p, tree *pre_p, tree *post_p) if (init) { + /* Try to avoid the temporary if possible. */ + if (TREE_CODE (init) == INDIRECT_REF + && !TREE_SIDE_EFFECTS (init) + && !TARGET_EXPR_CLEANUP (targ)) + { + *expr_p = init; + return GS_OK; + } + /* TARGET_EXPR temps aren't part of the enclosing block, so add it to the temps list. */ gimple_add_tmp_var (temp); diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 5d9b87bbc28..c7b641144d2 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2006-01-30 Richard Guenther + + PR c++/23372 + * gcc.dg/pr23372-1.C: New testcase. + 2006-01-29 Diego Novillo * gcc.dg/gomp/pr25874.c: New test. diff --git a/gcc/testsuite/gcc.dg/pr23372-1.c b/gcc/testsuite/gcc.dg/pr23372-1.c new file mode 100644 index 00000000000..14149474eb3 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr23372-1.c @@ -0,0 +1,10 @@ +/* { dg-do compile } */ +/* { dg-options "-Os" } */ + +struct A { + int a[1000]; +}; +void f(struct A); +void g(struct A *a) { f(*a); } + +/* { dg-final { scan-assembler-times "memcpy" 1 } } */ -- 2.30.2