From eb9d6cc91a423f7825a46317e1882e2e9297c76f Mon Sep 17 00:00:00 2001 From: Renlin Li Date: Mon, 27 Apr 2015 11:36:12 +0100 Subject: [PATCH] [AArch64] Don't try to align insn in non-executale section 2015-04-27 Renlin Li gas/ * config/tc-aarch64.c (s_aarch64_inst): Don't align code for non-text section. (md_assemble): Likewise, move the align code outside the loop. --- gas/ChangeLog | 6 ++++++ gas/config/tc-aarch64.c | 22 ++++++++++------------ 2 files changed, 16 insertions(+), 12 deletions(-) diff --git a/gas/ChangeLog b/gas/ChangeLog index 29870dd6c88..5b9b50c389a 100644 --- a/gas/ChangeLog +++ b/gas/ChangeLog @@ -1,3 +1,9 @@ +2015-04-27 Renlin Li + + * config/tc-aarch64.c (s_aarch64_inst): Don't align code for non-text + section. + (md_assemble): Likewise, move the align code outside the loop. + 2015-04-24 Jim Wilson * config/tc-aarch64.c (aarch64_cpus): Add CRC and CRYPTO features diff --git a/gas/config/tc-aarch64.c b/gas/config/tc-aarch64.c index dec50c757ca..646deb64482 100644 --- a/gas/config/tc-aarch64.c +++ b/gas/config/tc-aarch64.c @@ -1858,10 +1858,9 @@ s_aarch64_inst (int ignored ATTRIBUTE_UNUSED) /* Sections are assumed to start aligned. In executable section, there is no MAP_DATA symbol pending. So we only align the address during MAP_DATA --> MAP_INSN transition. - For other sections, this is not guaranteed, align it anyway. */ + For other sections, this is not guaranteed. */ enum mstate mapstate = seg_info (now_seg)->tc_segment_info_data.mapstate; - if (!need_pass_2 && ((subseg_text_p (now_seg) && mapstate == MAP_DATA) - || !subseg_text_p (now_seg))) + if (!need_pass_2 && subseg_text_p (now_seg) && mapstate == MAP_DATA) frag_align_code (2, 0); #ifdef OBJ_ELF @@ -5690,6 +5689,14 @@ md_assemble (char *str) init_operand_error_report (); + /* Sections are assumed to start aligned. In executable section, there is no + MAP_DATA symbol pending. So we only align the address during + MAP_DATA --> MAP_INSN transition. + For other sections, this is not guaranteed. */ + enum mstate mapstate = seg_info (now_seg)->tc_segment_info_data.mapstate; + if (!need_pass_2 && subseg_text_p (now_seg) && mapstate == MAP_DATA) + frag_align_code (2, 0); + saved_cond = inst.cond; reset_aarch64_instruction (&inst); inst.cond = saved_cond; @@ -5705,15 +5712,6 @@ md_assemble (char *str) dump_opcode_operands (opcode); #endif /* DEBUG_AARCH64 */ - /* Sections are assumed to start aligned. In executable section, there is no - MAP_DATA symbol pending. So we only align the address during - MAP_DATA --> MAP_INSN transition. - For other sections, this is not guaranteed, align it anyway. */ - enum mstate mapstate = seg_info (now_seg)->tc_segment_info_data.mapstate; - if (!need_pass_2 && ((subseg_text_p (now_seg) && mapstate == MAP_DATA) - || !subseg_text_p (now_seg))) - frag_align_code (2, 0); - mapping_state (MAP_INSN); inst_base = &inst.base; -- 2.30.2