From ec6c8338a89b0ec022b66ed3efdd1577e6449d6d Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Thu, 12 Sep 2019 21:23:37 -0400 Subject: [PATCH] gdb: Force use of float version of log10 This commit: commit aa17805fb9a3a1983a510ba425b682fba03410c2 Date: Sat Aug 31 23:44:40 2019 +0100 gdb: Have 'maint info sections' print all sections again introduced a use of log10 that took an int as a parameter. Unfortunately this was causing a compilation error on Solaris, see: https://sourceware.org/ml/gdb-patches/2019-09/msg00230.html https://sourceware.org/ml/gdb-patches/2019-09/msg00231.html because there was only a float, double, or long double version of log10, and the compiler doesn't know which to choose. This commit should resolve this issue by casting the argument to float. gdb/ChangeLog: * maint.c (maint_print_section_data::maint_print_section_data): Force use of 'float log10 (float)' by casting the argument to float. --- gdb/ChangeLog | 6 ++++++ gdb/maint.c | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 4158161393e..147882447e2 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2019-09-12 Andrew Burgess + + * maint.c (maint_print_section_data::maint_print_section_data): + Force use of 'float log10 (float)' by casting the argument to + float. + 2019-09-12 Andrew Burgess * maint.c: Add 'cmath' include. diff --git a/gdb/maint.c b/gdb/maint.c index 286ec310135..1a621a17191 100644 --- a/gdb/maint.c +++ b/gdb/maint.c @@ -301,7 +301,7 @@ struct maint_print_section_data arg(arg) { int section_count = gdb_bfd_count_sections (abfd); - index_digits = ((int) log10 (section_count)) + 1; + index_digits = ((int) log10 ((float) section_count)) + 1; } private: -- 2.30.2