From ed9c59b0e93e994b7f1ffe13ce26f647d81b1a9a Mon Sep 17 00:00:00 2001 From: Gabe Black Date: Thu, 25 Jun 2020 16:03:17 -0700 Subject: [PATCH] arm: Add a missing "break" in an ARM miscreg decode function. This change accidentally left out a "break" which gcc found and complained about. arch-arm: Implementation of Hardware Breakpoint exception This change adds in the break based on the assumption that the function should not fall through that case to the next. Change-Id: Id728a0c9a504d1b6d231d3fe1e7c5ece05d3ac4d Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/30654 Reviewed-by: Jordi Vaquero Maintainer: Giacomo Travaglini Tested-by: kokoro --- src/arch/arm/miscregs.cc | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/arch/arm/miscregs.cc b/src/arch/arm/miscregs.cc index 86b3aaa94..2bdbaa48d 100644 --- a/src/arch/arm/miscregs.cc +++ b/src/arch/arm/miscregs.cc @@ -201,8 +201,6 @@ decodeCP14Reg(unsigned crn, unsigned opc1, unsigned crm, unsigned opc2) return MISCREG_DBGBXVR15; } break; - } - switch (opc2) { case 4: switch (crm) { case 0: @@ -216,6 +214,7 @@ decodeCP14Reg(unsigned crn, unsigned opc1, unsigned crm, unsigned opc2) } break; } + break; case 6: switch (crm) { case 0: -- 2.30.2