From edd45af9ba1952e2656af5772c5c5704b1884eba Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Mon, 3 Jun 2019 13:15:49 -0700 Subject: [PATCH] nir: Drop lower_fmod64 option. MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit nir_lower_doubles offers a wide variety of fp64 lowering, including lowering fmod@64. The version there also better handles imprecisions due to lowered frcp@64. Let's consolidate on one version. Reviewed-by: Marek Olšák --- src/compiler/nir/nir.h | 1 - src/compiler/nir/nir_opt_algebraic.py | 1 - src/intel/compiler/brw_compiler.c | 1 - 3 files changed, 3 deletions(-) diff --git a/src/compiler/nir/nir.h b/src/compiler/nir/nir.h index 7930e164acb..794b1833436 100644 --- a/src/compiler/nir/nir.h +++ b/src/compiler/nir/nir.h @@ -2250,7 +2250,6 @@ typedef struct nir_shader_compiler_options { bool lower_fsqrt; bool lower_fmod16; bool lower_fmod32; - bool lower_fmod64; /** Lowers ibitfield_extract/ubitfield_extract to ibfe/ubfe. */ bool lower_bitfield_extract; /** Lowers ibitfield_extract/ubitfield_extract to bfm, compares, shifts. */ diff --git a/src/compiler/nir/nir_opt_algebraic.py b/src/compiler/nir/nir_opt_algebraic.py index d36131ae1ac..c0894ce42c9 100644 --- a/src/compiler/nir/nir_opt_algebraic.py +++ b/src/compiler/nir/nir_opt_algebraic.py @@ -773,7 +773,6 @@ optimizations.extend([ # Misc. lowering (('fmod@16', a, b), ('fsub', a, ('fmul', b, ('ffloor', ('fdiv', a, b)))), 'options->lower_fmod16'), (('fmod@32', a, b), ('fsub', a, ('fmul', b, ('ffloor', ('fdiv', a, b)))), 'options->lower_fmod32'), - (('fmod@64', a, b), ('fsub', a, ('fmul', b, ('ffloor', ('fdiv', a, b)))), 'options->lower_fmod64'), (('frem', a, b), ('fsub', a, ('fmul', b, ('ftrunc', ('fdiv', a, b)))), 'options->lower_fmod32'), (('uadd_carry@32', a, b), ('b2i', ('ult', ('iadd', a, b), a)), 'options->lower_uadd_carry'), (('usub_borrow@32', a, b), ('b2i', ('ult', a, b)), 'options->lower_usub_borrow'), diff --git a/src/intel/compiler/brw_compiler.c b/src/intel/compiler/brw_compiler.c index 536dc86ab78..9da549f7448 100644 --- a/src/intel/compiler/brw_compiler.c +++ b/src/intel/compiler/brw_compiler.c @@ -36,7 +36,6 @@ .lower_flrp16 = true, \ .lower_fmod16 = true, \ .lower_fmod32 = true, \ - .lower_fmod64 = false, \ .lower_bitfield_extract = true, \ .lower_bitfield_insert = true, \ .lower_uadd_carry = true, \ -- 2.30.2