From edfa7c684d329708dcee733fcb552bed9d931621 Mon Sep 17 00:00:00 2001 From: Marek Polacek Date: Tue, 21 Apr 2020 18:11:33 -0400 Subject: [PATCH] c++: Add test for c++/93807 This PR was initially accepts-invalid, but I think it's actually valid C++20 code. My reasoning is that in C++20 we no longer require the declaration of operator== (#if-defed in the test), because C++20's [temp.names]/2 says "A name is also considered to refer to a template if it is an unqualified-id followed by a < and name lookup either finds one or more functions or finds nothing." so when we're parsing constexpr friend bool operator==(T lhs, const Foo& rhs); we treat "operator==" as a template name, because name lookup of "operator==" found nothing and we have an operator-function-id, which is an unqualified-id, and it's followed by a <. So the declaration isn't needed to treat "operator==" as a template-id. PR c++/93807 * g++.dg/cpp2a/fn-template20.C: New test. --- gcc/testsuite/ChangeLog | 5 ++++ gcc/testsuite/g++.dg/cpp2a/fn-template20.C | 34 ++++++++++++++++++++++ 2 files changed, 39 insertions(+) create mode 100644 gcc/testsuite/g++.dg/cpp2a/fn-template20.C diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 72cc7665ed4..955418f669a 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2020-04-22 Marek Polacek + + PR c++/93807 + * g++.dg/cpp2a/fn-template20.C: New test. + 2020-04-22 Duan bo PR testsuite/94712 diff --git a/gcc/testsuite/g++.dg/cpp2a/fn-template20.C b/gcc/testsuite/g++.dg/cpp2a/fn-template20.C new file mode 100644 index 00000000000..c558ad1f2b6 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp2a/fn-template20.C @@ -0,0 +1,34 @@ +// PR c++/93807 +// { dg-do compile { target c++11 } } + +// In C++17, we need the following declaration to treat operator== as +// a template name. In C++20, this is handled by [temp.names]/2. +#if __cplusplus <= 201703L +template +class Foo; +template +constexpr bool operator==(T lhs, const Foo& rhs); +#endif + +template +class Foo { +public: + constexpr Foo(T k) : mK(k) {} + + constexpr friend bool operator==(T lhs, const Foo& rhs); +private: + T mK; +}; + +template +constexpr bool +operator==(T lhs, const Foo& rhs) +{ + return lhs == rhs.mK; +} + +int +main () +{ + return 1 == Foo(1) ? 0 : 1; +} -- 2.30.2