From ee59d1ad773aaa720e893446fb46f4e9f3fe5940 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Tue, 2 Jun 2020 14:03:58 -0400 Subject: [PATCH] panfrost: Update MALI_EARLY_Z description Via the ES3.1 early-z testing force, I've confirmed this bit is e-z. I've also confirmed e-z must be disabled for global writes, as expected. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/include/panfrost-job.h | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/panfrost/include/panfrost-job.h b/src/panfrost/include/panfrost-job.h index 0008bb18015..66db429e3b9 100644 --- a/src/panfrost/include/panfrost-job.h +++ b/src/panfrost/include/panfrost-job.h @@ -390,11 +390,11 @@ enum mali_format { /* Should be set when the fragment shader updates the depth value. */ #define MALI_WRITES_Z (1 << 4) -/* Should the hardware perform early-Z testing? Normally should be set - * for performance reasons. Clear if you use: discard, - * alpha-to-coverage... * It's also possible this disables - * forward-pixel kill; we're not quite sure which bit is which yet. - * TODO: How does this interact with blending?*/ +/* Should the hardware perform early-Z testing? Set if the shader does not use + * discard, alpha-to-coverage, shader depth writes, and if the shader has no + * side effects (writes to global memory or images) unless early-z testing is + * forced in the shader. + */ #define MALI_EARLY_Z (1 << 6) -- 2.30.2