From ee772f3256afc191e67ae662bcbdfe6ece12d1cc Mon Sep 17 00:00:00 2001 From: "Yann E. MORIN" Date: Sat, 11 Apr 2020 10:12:27 +0200 Subject: [PATCH] package/pkg-generic.mk: don't set INSTALL_{TARGET, STAGING, IMAGES} for host packages By their very nature, host packages have no target, staging, or images install steps; they have a single install step, that is always performed. As such, setting the corresponding _INSTALL_{TARGET,STAGING,IMAGES} variables does not make sense for host packages. However, people (and scripts) may get confused when they process the output of printvars, e.g.: $ make printvars VARS=HOST_LIBTOOL_INSTALL_TARGET HOST_LIBTOOL_INSTALL_TARGET=YES Only set those variables for target packages. There is no corresponding variable for host packages, as they are always installed (and only once). Signed-off-by: Yann E. MORIN Cc: Vadim Kochan Cc: Thomas Petazzoni Cc: Arnout Vandecappelle Cc: eeppeliteloop@gmail.com Signed-off-by: Thomas Petazzoni --- package/pkg-generic.mk | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 7679c41556..8cd5a7ff62 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -706,10 +706,6 @@ $(2)_FINAL_RECURSIVE_RDEPENDENCIES = $$(sort \ ) \ $$($(2)_FINAL_RECURSIVE_RDEPENDENCIES__X)) -$(2)_INSTALL_STAGING ?= NO -$(2)_INSTALL_IMAGES ?= NO -$(2)_INSTALL_TARGET ?= YES - # define sub-target stamps $(2)_TARGET_INSTALL_TARGET = $$($(2)_DIR)/.stamp_target_installed $(2)_TARGET_INSTALL_STAGING = $$($(2)_DIR)/.stamp_staging_installed @@ -770,6 +766,9 @@ $(1): $(1)-install ifeq ($$($(2)_TYPE),host) $(1)-install: $(1)-install-host else +$(2)_INSTALL_STAGING ?= NO +$(2)_INSTALL_IMAGES ?= NO +$(2)_INSTALL_TARGET ?= YES $(1)-install: $(1)-install-staging $(1)-install-target $(1)-install-images endif -- 2.30.2