From eeb6aca93d1da2d878c6cd6a002f1f8255ae1f20 Mon Sep 17 00:00:00 2001 From: whitequark Date: Wed, 3 Jul 2019 13:25:12 +0000 Subject: [PATCH] compat.fhdl.specials: use "sync" as default domain, not "sys". In compat.fhdl.module, we already default to "sync" as the default clocked domain. Using "sys" in memories only would be inconsistent and result in more bugs. --- nmigen/compat/fhdl/specials.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nmigen/compat/fhdl/specials.py b/nmigen/compat/fhdl/specials.py index c18c14e..a98afbc 100644 --- a/nmigen/compat/fhdl/specials.py +++ b/nmigen/compat/fhdl/specials.py @@ -65,7 +65,7 @@ class Tristate(Elaboratable): class _MemoryPort(CompatModule): def __init__(self, adr, dat_r, we=None, dat_w=None, async_read=False, re=None, - we_granularity=0, mode=WRITE_FIRST, clock_domain="sys"): + we_granularity=0, mode=WRITE_FIRST, clock_domain="sync"): self.adr = adr self.dat_r = dat_r self.we = we @@ -86,7 +86,7 @@ def elaborate(self, platform): class CompatMemory(NativeMemory): @deprecated("instead of `get_port()`, use `read_port()` and `write_port()`") def get_port(self, write_capable=False, async_read=False, has_re=False, we_granularity=0, - mode=WRITE_FIRST, clock_domain="sys"): + mode=WRITE_FIRST, clock_domain="sync"): if we_granularity >= self.width: warnings.warn("do not specify `we_granularity` greater than memory width, as it " "is a hard error in non-compatibility mode", -- 2.30.2