From ef190c93b07f04d61e28d70bb9a360fd2f3efbde Mon Sep 17 00:00:00 2001 From: David Malcolm Date: Thu, 15 Nov 2018 14:01:29 +0000 Subject: [PATCH] graphite: add missing dump_enabled_p checks (PR tree-optimization/88015) gcc/ChangeLog: PR tree-optimization/88015 * graphite-isl-ast-to-gimple.c (translate_isl_ast_to_gimple::scop_to_isl_ast): Add missing check for dump_enabled_p. * graphite-sese-to-poly.c (build_poly_scop): Likewise. From-SVN: r266184 --- gcc/ChangeLog | 8 ++++++++ gcc/graphite-isl-ast-to-gimple.c | 25 ++++++++++++++----------- gcc/graphite-sese-to-poly.c | 3 ++- 3 files changed, 24 insertions(+), 12 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index f60b32166fe..d9857fef20c 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,11 @@ +2018-11-15 David Malcolm + + PR tree-optimization/88015 + * graphite-isl-ast-to-gimple.c + (translate_isl_ast_to_gimple::scop_to_isl_ast): Add missing check + for dump_enabled_p. + * graphite-sese-to-poly.c (build_poly_scop): Likewise. + 2018-11-15 Richard Biener PR middle-end/88029 diff --git a/gcc/graphite-isl-ast-to-gimple.c b/gcc/graphite-isl-ast-to-gimple.c index e2dbf6fbf9d..cc93fb94daf 100644 --- a/gcc/graphite-isl-ast-to-gimple.c +++ b/gcc/graphite-isl-ast-to-gimple.c @@ -1411,17 +1411,20 @@ scop_to_isl_ast (scop_p scop) isl_ctx_set_max_operations (scop->isl_context, old_max_operations); if (isl_ctx_last_error (scop->isl_context) != isl_error_none) { - dump_user_location_t loc = find_loop_location - (scop->scop_info->region.entry->dest->loop_father); - if (isl_ctx_last_error (scop->isl_context) == isl_error_quota) - dump_printf_loc (MSG_MISSED_OPTIMIZATION, loc, - "loop nest not optimized, AST generation timed out " - "after %d operations [--param max-isl-operations]\n", - max_operations); - else - dump_printf_loc (MSG_MISSED_OPTIMIZATION, loc, - "loop nest not optimized, ISL AST generation " - "signalled an error\n"); + if (dump_enabled_p ()) + { + dump_user_location_t loc = find_loop_location + (scop->scop_info->region.entry->dest->loop_father); + if (isl_ctx_last_error (scop->isl_context) == isl_error_quota) + dump_printf_loc (MSG_MISSED_OPTIMIZATION, loc, + "loop nest not optimized, AST generation timed out " + "after %d operations [--param max-isl-operations]\n", + max_operations); + else + dump_printf_loc (MSG_MISSED_OPTIMIZATION, loc, + "loop nest not optimized, ISL AST generation " + "signalled an error\n"); + } isl_ast_node_free (ast_isl); return NULL; } diff --git a/gcc/graphite-sese-to-poly.c b/gcc/graphite-sese-to-poly.c index 69898d4ffd8..1d41cffeb04 100644 --- a/gcc/graphite-sese-to-poly.c +++ b/gcc/graphite-sese-to-poly.c @@ -1218,7 +1218,8 @@ build_poly_scop (scop_p scop) enum isl_error err = isl_ctx_last_error (scop->isl_context); isl_ctx_reset_error (scop->isl_context); isl_options_set_on_error (scop->isl_context, old_err); - if (err != isl_error_none) + if (err != isl_error_none + && dump_enabled_p ()) dump_printf (MSG_MISSED_OPTIMIZATION, "ISL error while building poly scop\n"); -- 2.30.2