From ef621b15e0b14f8fc0dc5940bc6b14a9aaa40ea3 Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Tue, 1 Mar 2016 12:39:49 -0800 Subject: [PATCH] Update PR ld/12365 test for GCC 6 PR ld/12365 test is to verify that linker catches the reference to undefined symbol error caused by a GCC bug. Since the GCC bug has been fixed in GCC 6, update the test to verify that there is no reference to undefined symbol in executable * testsuite/ld-plugin/lto.exp: Update PR ld/12365 test for GCC 6. --- ld/ChangeLog | 4 ++++ ld/testsuite/ld-plugin/lto.exp | 13 ++++++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/ld/ChangeLog b/ld/ChangeLog index 472ffa99635..51061a810eb 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,7 @@ +2016-03-01 H.J. Lu + + * testsuite/ld-plugin/lto.exp: Update PR ld/12365 test for GCC 6. + 2016-03-01 H.J. Lu * testsuite/ld-elf/pr19162.d: Skip arc target. diff --git a/ld/testsuite/ld-plugin/lto.exp b/ld/testsuite/ld-plugin/lto.exp index 7bf67eca4e0..6330a178aba 100644 --- a/ld/testsuite/ld-plugin/lto.exp +++ b/ld/testsuite/ld-plugin/lto.exp @@ -408,9 +408,20 @@ if { [at_least_gcc_version 4 7] } { || [istarget "x86_64-*-linux*"] || [istarget "amd64-*-linux*"]) } { set testname "PR ld/12365" - set exec_output [run_host_cmd "$CC" "-O2 -flto -flto-partition=none -fuse-linker-plugin tmpdir/pr12365a.o tmpdir/pr12365b.o tmpdir/pr12365c.o"] + set exec_output [run_host_cmd "$CC" "-O2 -flto -flto-partition=none -fuse-linker-plugin -o tmpdir/pr12365 tmpdir/pr12365a.o tmpdir/pr12365b.o tmpdir/pr12365c.o"] if { [ regexp "undefined reference to `my_bcopy'" $exec_output ] } { + # Linker should catch the reference to undefined `my_bcopy' + # error caused by a GCC bug. pass $testname + } elseif { [ string match "" $exec_output ] } { + global READELF + set exec_output [run_host_cmd "$READELF" "-s -W tmpdir/pr12365"] + if { [ regexp "my_bcopy" $exec_output ] } { + # Verify that there is no `my_bcopy' symbol in executable. + fail $testname + } { + pass $testname + } } { fail $testname } -- 2.30.2