From efe2296bde30c22124ed31b70b7d860339927471 Mon Sep 17 00:00:00 2001 From: Simon Marchi Date: Thu, 11 May 2023 13:33:51 -0400 Subject: [PATCH] gdb: remove unnecessary call to std::string constructor I spotted this explicit call to std::string, which creates an unnecessary temporary extra std::string, while calling emplace_back. I'm not sure if it has any impact in an optimized build, maybe the compiler elides it. But still, it's unnecessary. Change-Id: I873337ea91db29ac06267aff8fc12dcf52824cac Approved-By: Tom Tromey --- gdb/cli/cli-decode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/cli/cli-decode.c b/gdb/cli/cli-decode.c index 948592a6f62..b84ce8375fb 100644 --- a/gdb/cli/cli-decode.c +++ b/gdb/cli/cli-decode.c @@ -155,7 +155,7 @@ cmd_list_element::command_components () const if (this->prefix != nullptr) result = this->prefix->command_components (); - result.emplace_back (std::string (this->name)); + result.emplace_back (this->name); return result; } -- 2.30.2