From f0aec8643830a50812aeec0296086ed338aac678 Mon Sep 17 00:00:00 2001 From: Mihail Ionescu Date: Tue, 21 Jan 2020 10:11:35 +0000 Subject: [PATCH] [PATCH, GCC/ARM] Fix clear_operation_p uninitialised variable 2020-01-21 Mihail-Calin Ionescu * gcc/config/arm/arm.c (clear_operation_p): Initialise last_regno, skip first iteration based on the first_set value and use ints instead of the unnecessary HOST_WIDE_INTs. --- gcc/ChangeLog | 7 +++++++ gcc/config/arm/arm.c | 13 +++++++------ 2 files changed, 14 insertions(+), 6 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 4f38f24317f..8c17e5992d2 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,10 @@ +2020-01-21 Mihail-Calin Ionescu + + * gcc/config/arm/arm.c (clear_operation_p): + Initialise last_regno, skip first iteration + based on the first_set value and use ints instead + of the unnecessary HOST_WIDE_INTs. + 2020-01-21 Jakub Jelinek PR target/93073 diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index c47fc232f39..b54382dbff3 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -13751,13 +13751,14 @@ ldm_stm_operation_p (rtx op, bool load, machine_mode mode, bool clear_operation_p (rtx op, bool vfp) { - unsigned regno, last_regno; + unsigned regno; + unsigned last_regno = INVALID_REGNUM; rtx elt, reg, zero; - HOST_WIDE_INT count = XVECLEN (op, 0); - HOST_WIDE_INT i, first_set = vfp ? 1 : 0; + int count = XVECLEN (op, 0); + int first_set = vfp ? 1 : 0; machine_mode expected_mode = vfp ? E_SFmode : E_SImode; - for (i = first_set; i < count; i++) + for (int i = first_set; i < count; i++) { elt = XVECEXP (op, 0, i); @@ -13790,14 +13791,14 @@ clear_operation_p (rtx op, bool vfp) if (vfp) { - if (i != 1 && regno != last_regno + 1) + if (i != first_set && regno != last_regno + 1) return false; } else { if (regno == SP_REGNUM || regno == PC_REGNUM) return false; - if (i != 0 && regno <= last_regno) + if (i != first_set && regno <= last_regno) return false; } -- 2.30.2