From f18eeb6b958acd5e1590ca4a73231486b749be9b Mon Sep 17 00:00:00 2001 From: Jakub Jelinek Date: Thu, 8 Oct 2020 11:56:15 +0200 Subject: [PATCH] arm: Fix ICE on glibc compilation after my DIVMOD optimization [PR97322] The arm target hook for divmod wasn't prepared to handle constants passed to the function. 2020-10-08 Jakub Jelinek PR target/97322 * config/arm/arm.c (arm_expand_divmod_libfunc): Pass mode instead of GET_MODE (op0) or GET_MODE (op1) to emit_library_call_value. * gcc.dg/pr97322.c: New test. --- gcc/config/arm/arm.c | 4 +--- gcc/testsuite/gcc.dg/pr97322.c | 17 +++++++++++++++++ 2 files changed, 18 insertions(+), 3 deletions(-) create mode 100644 gcc/testsuite/gcc.dg/pr97322.c diff --git a/gcc/config/arm/arm.c b/gcc/config/arm/arm.c index 5fdc1439636..5d9c995e5c6 100644 --- a/gcc/config/arm/arm.c +++ b/gcc/config/arm/arm.c @@ -33275,9 +33275,7 @@ arm_expand_divmod_libfunc (rtx libfunc, machine_mode mode, = smallest_int_mode_for_size (2 * GET_MODE_BITSIZE (mode)); rtx libval = emit_library_call_value (libfunc, NULL_RTX, LCT_CONST, - libval_mode, - op0, GET_MODE (op0), - op1, GET_MODE (op1)); + libval_mode, op0, mode, op1, mode); rtx quotient = simplify_gen_subreg (mode, libval, libval_mode, 0); rtx remainder = simplify_gen_subreg (mode, libval, libval_mode, diff --git a/gcc/testsuite/gcc.dg/pr97322.c b/gcc/testsuite/gcc.dg/pr97322.c new file mode 100644 index 00000000000..f253c0d7616 --- /dev/null +++ b/gcc/testsuite/gcc.dg/pr97322.c @@ -0,0 +1,17 @@ +/* PR target/97322 */ +/* { dg-do compile } */ +/* { dg-options "-O2" } */ + +void +foo (unsigned long long x, unsigned long long *y) +{ + y[0] = x / 10; + y[1] = x % 10; +} + +void +bar (unsigned int x, unsigned int *y) +{ + y[0] = x / 10; + y[1] = x % 10; +} -- 2.30.2