From f365488eaaaaab8eb61bc614a105f397c5c80a6f Mon Sep 17 00:00:00 2001 From: Brian Paul Date: Wed, 27 Apr 2016 10:42:39 -0600 Subject: [PATCH] mesa: improve comment on _mesa_check_disallowed_mapping(), return bool MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit The old comment was a bit terse. Also, change the function return type to bool. Reviewed-by: Marek Olšák Reviewed-by: Ian Romanick --- src/mesa/main/bufferobj.h | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/src/mesa/main/bufferobj.h b/src/mesa/main/bufferobj.h index a5bfe886b39..5dcc55301ce 100644 --- a/src/mesa/main/bufferobj.h +++ b/src/mesa/main/bufferobj.h @@ -45,8 +45,14 @@ _mesa_bufferobj_mapped(const struct gl_buffer_object *obj, return obj->Mappings[index].Pointer != NULL; } -/** Can we not use this buffer while mapped? */ -static inline GLboolean +/** + * Check whether the given buffer object is illegally mapped prior to + * drawing from (or reading back to) the buffer. + * Note that it's legal for a buffer to be mapped at draw/readback time + * if it was mapped persistently (See GL_ARB_buffer_storage spec). + * \return true if the buffer is illegally mapped, false otherwise + */ +static inline bool _mesa_check_disallowed_mapping(const struct gl_buffer_object *obj) { return _mesa_bufferobj_mapped(obj, MAP_USER) && -- 2.30.2