From f37059ea22267e5b426df1732a2ae7ab45b1d848 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Alex=20Benn=C3=A9e?= Date: Wed, 23 Dec 2020 16:36:16 -0500 Subject: [PATCH] Clarify language for the '?' packet MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Both QEMU and kgdb make the assumption that the '?' packet is only sent during the initial setup of a gdbstub connection. Both use that knowledge to reset breakpoints and ensure the gdbstub is in a clean-state on a resumed connection. This can cause confusion for others implementing clients that speak to gdbstub devices. To avoid that make the language clearer that this is a start-up query packet that you only expect to see once. Signed-off-by: Alex Bennée gdb/doc/ChangeLog: * gdb.texinfo (Packets): Clarify language for ? packet. Change-Id: Iae25d3110fe28b8d2467704962a6889e55224ca5 --- gdb/doc/ChangeLog | 4 ++++ gdb/doc/gdb.texinfo | 7 ++++--- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gdb/doc/ChangeLog b/gdb/doc/ChangeLog index d56cec23ff9..1d88c926346 100644 --- a/gdb/doc/ChangeLog +++ b/gdb/doc/ChangeLog @@ -1,3 +1,7 @@ +2020-12-23 Alex Bennée + + * gdb.texinfo (Packets): Clarify language for ? packet. + 2020-12-21 Joel Brobecker * gdb.texinfo (Requirements): Add GMP to list of requirements. diff --git a/gdb/doc/gdb.texinfo b/gdb/doc/gdb.texinfo index 617a3641382..93e722881a3 100644 --- a/gdb/doc/gdb.texinfo +++ b/gdb/doc/gdb.texinfo @@ -39502,9 +39502,10 @@ The remote target both supports and has enabled extended mode. @item ? @cindex @samp{?} packet @anchor{? packet} -Indicate the reason the target halted. The reply is the same as for -step and continue. This packet has a special interpretation when the -target is in non-stop mode; see @ref{Remote Non-Stop}. +This is sent when connection is first established to query the reason +the target halted. The reply is the same as for step and continue. +This packet has a special interpretation when the target is in +non-stop mode; see @ref{Remote Non-Stop}. Reply: @xref{Stop Reply Packets}, for the reply specifications. -- 2.30.2