From f3726a08743a100c7e163489800fd0560da015b9 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Thu, 26 Mar 2020 10:06:49 -0400 Subject: [PATCH] pan/bi: Fix overzealous write barriers It's possible this triggers an INSTR_INVALID_ENC. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/bifrost/bi_schedule.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/panfrost/bifrost/bi_schedule.c b/src/panfrost/bifrost/bi_schedule.c index 4adab3bc60e..589c84897ac 100644 --- a/src/panfrost/bifrost/bi_schedule.c +++ b/src/panfrost/bifrost/bi_schedule.c @@ -110,7 +110,10 @@ bi_schedule(bi_context *ctx) ids = ids & 1; last_id = u->scoreboard_id; u->back_to_back = true; - u->data_register_write_barrier = true; + + /* Rule: first instructions cannot have write barriers */ + if (!is_first) + u->data_register_write_barrier = true; u->constant_count = 1; u->constants[0] = ins->constant.u64; -- 2.30.2