From f47674be8e90a84edae49ec2b781201ea2f050bd Mon Sep 17 00:00:00 2001 From: "Pavel I. Kryukov" Date: Sun, 1 Dec 2019 01:40:21 +0300 Subject: [PATCH] sim-utils.c: prevent buffer overflow. Representation of max 32-bit integer is 10 chars. The potential issue is observed by GCC 7 targeted to AArch64. sim/common/ChangeLog: 2019-12-01 Pavel I. Kryukov * sim-utils.c: Prevent buffer overflow. --- sim/common/ChangeLog | 4 ++++ sim/common/sim-utils.c | 8 ++++---- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/sim/common/ChangeLog b/sim/common/ChangeLog index a7ec5c7121e..12d900e8b68 100644 --- a/sim/common/ChangeLog +++ b/sim/common/ChangeLog @@ -1,3 +1,7 @@ +2019-12-01 Pavel I. Kryukov + + * sim-utils.c: Prevent buffer overflow. + 2019-09-23 Dimitar Dimitrov * gennltvals.sh: Add PRU libgloss target. diff --git a/sim/common/sim-utils.c b/sim/common/sim-utils.c index e83a2e4d0c8..0c46662ff33 100644 --- a/sim/common/sim-utils.c +++ b/sim/common/sim-utils.c @@ -355,8 +355,8 @@ map_to_str (unsigned map) case io_map: return "io"; default: { - static char str[10]; - sprintf (str, "(%ld)", (long) map); + static char str[16]; + snprintf (str, sizeof(str), "(%ld)", (long) map); return str; } } @@ -385,8 +385,8 @@ access_to_str (unsigned access) case access_read_write_exec_io: return "read_write_exec_io"; default: { - static char str[10]; - sprintf (str, "(%ld)", (long) access); + static char str[16]; + snprintf (str, sizeof(str), "(%ld)", (long) access); return str; } } -- 2.30.2