From f4fcd63fa019c739fdf9de4aa984c4de96d4becd Mon Sep 17 00:00:00 2001 From: Ian Lance Taylor Date: Thu, 18 Jul 1996 19:49:56 +0000 Subject: [PATCH] add comments about magic numbers --- include/elf/common.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/include/elf/common.h b/include/elf/common.h index 3c3ed7e1b69..c93295a49d8 100644 --- a/include/elf/common.h +++ b/include/elf/common.h @@ -92,7 +92,11 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ /* If it is necessary to assign new unofficial EM_* values, please pick large random numbers (0x8523, 0xa7f2, etc.) to minimize the chances of collision - with official or non-GNU unofficial values. */ + with official or non-GNU unofficial values. + + NOTE: Do not just increment the most recent number by one. + Somebody else somewhere will do exactly the same thing, and you + will have a collision. Instead, pick a random number. */ /* Cygnus PowerPC ELF backend. Written in the absence of an ABI. */ #define EM_CYGNUS_POWERPC 0x9025 @@ -113,6 +117,8 @@ Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA 02111-1307, USA. */ #define EM_CYGNUS_D10V 0x9027 /* end-sanitize-d10v */ +/* See the above comment before you add a new EM_* value here. */ + /* Values for e_version */ #define EV_NONE 0 /* Invalid ELF version */ -- 2.30.2