From f57e61cdf634ed7ff8c18edee8154fd92f8b2583 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 22 Nov 2013 12:08:15 -0700 Subject: [PATCH] update comment in dw2-bad-cfi.S. Pedro asked me to add a comment to dw2-bad-cfi.S explaining the nature of the badness. I'm checking this in. 2013-11-22 Tom Tromey * gdb.dwarf2/dw2-bad-cfi.S: Update comment. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.dwarf2/dw2-bad-cfi.S | 3 ++- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index 74a1e06219d..e8bdc1052f6 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,7 @@ +2013-11-22 Tom Tromey + + * gdb.dwarf2/dw2-bad-cfi.S: Update comment. + 2013-11-22 Tom Tromey * gdb.dwarf2/dw2-bad-cfi.c: New file. diff --git a/gdb/testsuite/gdb.dwarf2/dw2-bad-cfi.S b/gdb/testsuite/gdb.dwarf2/dw2-bad-cfi.S index 9a97889a666..ab3a96729c3 100644 --- a/gdb/testsuite/gdb.dwarf2/dw2-bad-cfi.S +++ b/gdb/testsuite/gdb.dwarf2/dw2-bad-cfi.S @@ -26,7 +26,8 @@ callee: .loc 1 21 0 popq %rbp /* .cfi_def_cfa 7, 8 */ - # Our little lies. + /* The bug we introduce is that the return address column is + unspecified. In this case, there is no way to unwind. */ .cfi_undefined 6 .cfi_return_column 6 # SUCC: EXIT [100.0%] -- 2.30.2