From f5a1cdde80a5cc5f1b86be7e94fb062d3fd4aca9 Mon Sep 17 00:00:00 2001 From: Christophe Lyon Date: Mon, 9 Jul 2018 07:45:46 +0000 Subject: [PATCH] [ARM] Fix warning cannot find thumb start symbol In case params.thumb_entry_symbol has its default NULL value, using it to print a warning in gld${EMULATION_NAME}_finish results in a crash. Use h->root.string instead which either points to params.thumb_entry_symbol name or to entry_symbol name. 2018-07-09 Christophe Lyon * emultempl/armelf.em (gld${EMULATION_NAME}_finish): Use the right symbol name in case of warning. Change-Id: Iec61a833c0ad538b1440bf326ba67834c314dd63 --- ld/ChangeLog | 5 +++++ ld/emultempl/armelf.em | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/ld/ChangeLog b/ld/ChangeLog index b9bfc2b1f76..2d748f1a643 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,8 @@ +2018-07-09 Christophe Lyon + + * emultempl/armelf.em (gld${EMULATION_NAME}_finish): Use the right + symbol name in case of warning. + 2018-07-05 Jim Wilson * configure.tgt (riscv-*-*): Add as an alias for riscv32*-*-*. diff --git a/ld/emultempl/armelf.em b/ld/emultempl/armelf.em index 2d98064ed30..8cecedae158 100644 --- a/ld/emultempl/armelf.em +++ b/ld/emultempl/armelf.em @@ -499,7 +499,7 @@ gld${EMULATION_NAME}_finish (void) } else einfo (_("%P: warning: cannot find thumb start symbol %s\n"), - params.thumb_entry_symbol); + h->root.string); } /* This is a convenient point to tell BFD about target specific flags. -- 2.30.2