From f5ee8c54ed481f5c832f9364845680cc223a85b3 Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Mon, 18 Feb 2019 13:15:54 -0500 Subject: [PATCH] freedreno/ir3: fix legalize for vecN inputs The wrmask is handled in regmask_get()/regmask_set(), but it wasn't being propagated from SSA src to dst. So for example, an SSBO read value that is passed in as src2.y component to atomic op, wasn't getting the (sy) flag set. Causing lots of fail. Signed-off-by: Rob Clark --- src/freedreno/ir3/ir3.h | 1 + src/freedreno/ir3/ir3_context.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/src/freedreno/ir3/ir3.h b/src/freedreno/ir3/ir3.h index 356e9c60dea..918fce833f2 100644 --- a/src/freedreno/ir3/ir3.h +++ b/src/freedreno/ir3/ir3.h @@ -1076,6 +1076,7 @@ static inline struct ir3_register * __ssa_src(struct ir3_instruction *instr, flags |= IR3_REG_HALF; reg = ir3_reg_create(instr, 0, IR3_REG_SSA | flags); reg->instr = src; + reg->wrmask = src->regs[0]->wrmask; return reg; } diff --git a/src/freedreno/ir3/ir3_context.c b/src/freedreno/ir3/ir3_context.c index 1aab7396c3e..1fc453c15b3 100644 --- a/src/freedreno/ir3/ir3_context.c +++ b/src/freedreno/ir3/ir3_context.c @@ -340,6 +340,8 @@ ir3_create_collect(struct ir3_context *ctx, struct ir3_instruction *const *arr, ir3_reg_create(collect, 0, IR3_REG_SSA | flags)->instr = elem; } + collect->regs[0]->wrmask = MASK(arrsz); + return collect; } -- 2.30.2