From f60354ee72fdee988fd604994e8b8c8d75fe78be Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Wed, 8 Jul 2015 15:00:51 -0400 Subject: [PATCH] gallium: clarify reference counting for fence MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Nowhere was it spelled out that the state tracker may expect the pipe driver to unref the old fence. Signed-off-by: Rob Clark Reviewed-by: Michel Dänzer Reviewed-by: Marek Olšák --- src/gallium/include/pipe/p_context.h | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/gallium/include/pipe/p_context.h b/src/gallium/include/pipe/p_context.h index c2eedf8e7c7..d2c2e4c8d14 100644 --- a/src/gallium/include/pipe/p_context.h +++ b/src/gallium/include/pipe/p_context.h @@ -361,8 +361,14 @@ struct pipe_context { const void *clear_value, int clear_value_size); - /** Flush draw commands + /** + * Flush draw commands + * + * NOTE: use screen->fence_reference() (or equivalent) to transfer + * new fence ref to **fence, to ensure that previous fence is unref'd * + * \param fence if not NULL, an old fence to unref and transfer a + * new fence reference to * \param flags bitfield of enum pipe_flush_flags values. */ void (*flush)(struct pipe_context *pipe, -- 2.30.2