From f6895e8bd46a1533c607fe528a2da68b64e722dc Mon Sep 17 00:00:00 2001 From: Ali Saidi Date: Thu, 10 May 2012 18:04:26 -0500 Subject: [PATCH] Cache: Panic if you attempt to create a checkpoint with a cache in the system --- src/mem/cache/cache.hh | 6 ++++++ src/mem/cache/cache_impl.hh | 29 +++++++++++++++++++++++++++++ 2 files changed, 35 insertions(+) diff --git a/src/mem/cache/cache.hh b/src/mem/cache/cache.hh index d2110adce..ce68b2405 100644 --- a/src/mem/cache/cache.hh +++ b/src/mem/cache/cache.hh @@ -370,6 +370,12 @@ class Cache : public BaseCache * Find next request ready time from among possible sources. */ Tick nextMSHRReadyTime(); + + /** serialize the state of the caches + * We currently don't support checkpointing cache state, so this panics. + */ + virtual void serialize(std::ostream &os); + void unserialize(Checkpoint *cp, const std::string §ion); }; #endif // __CACHE_HH__ diff --git a/src/mem/cache/cache_impl.hh b/src/mem/cache/cache_impl.hh index 008bbb8d9..3312fc941 100644 --- a/src/mem/cache/cache_impl.hh +++ b/src/mem/cache/cache_impl.hh @@ -1539,6 +1539,35 @@ Cache::nextMSHRReadyTime() return nextReady; } +template +void +Cache::serialize(std::ostream &os) +{ + warn("*** Creating checkpoints with caches is not supported. ***\n"); + warn(" Remove any caches before taking checkpoints\n"); + warn(" This checkpoint will not restore correctly and dirty data in " + "the cache will be lost!\n"); + + // Since we don't write back the data dirty in the caches to the physical + // memory if caches exist in the system we won't be able to restore + // from the checkpoint as any data dirty in the caches will be lost. + + bool bad_checkpoint = true; + SERIALIZE_SCALAR(bad_checkpoint); +} + +template +void +Cache::unserialize(Checkpoint *cp, const std::string §ion) +{ + bool bad_checkpoint; + UNSERIALIZE_SCALAR(bad_checkpoint); + if (bad_checkpoint) { + fatal("Restoring from checkpoints with caches is not supported in the " + "classic memory system. Please remove any caches before taking " + "checkpoints.\n"); + } +} /////////////// // -- 2.30.2