From f6e49d5ad0fde19a074644491475470d684dd721 Mon Sep 17 00:00:00 2001 From: Ernestas Kulik Date: Thu, 30 Aug 2018 19:02:47 +0300 Subject: [PATCH] vc4: Fix leak in HW queries error path Reported by Coverity: in the case where there exist hardware and non-hardware queries, the code does not jump to err_free_query and leaks the query. CID: 1430194 Signed-off-by: Ernestas Kulik Fixes: 9ea90ffb98fb ("broadcom/vc4: Add support for HW perfmon") --- src/gallium/drivers/vc4/vc4_query.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/vc4/vc4_query.c b/src/gallium/drivers/vc4/vc4_query.c index 6e4681e93cc..f08785f457f 100644 --- a/src/gallium/drivers/vc4/vc4_query.c +++ b/src/gallium/drivers/vc4/vc4_query.c @@ -132,7 +132,7 @@ vc4_create_batch_query(struct pipe_context *pctx, unsigned num_queries, /* We can't mix HW and non-HW queries. */ if (nhwqueries && nhwqueries != num_queries) - return NULL; + goto err_free_query; if (!nhwqueries) return (struct pipe_query *)query; -- 2.30.2