From f6e59911e52161527d1d416e6807b0bc4d639011 Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Mon, 16 Dec 2019 21:23:02 -0800 Subject: [PATCH] ci: Enable -Werror on the meson-i386 build. I find warnings to be very disruptive to my workflow (using emacs's "go to next error" feature), and I periodically have to go clean up other people's drivers to get back to finding my own warnings in the noise. I know I'm not the only one doing something like this. We don't want to enable -Werror by default in builds, since it means that end users will have builds spuriously fail based on what compiler version and opt flags they have compared to what the devs are using. However, it is quite easy to have CI ensure that we at least don't introduce warnings on the compiler version that it uses. For now I've just enabled it on meson-i386 to cover a bunch of Mesa core and get us started on ratcheting up warnings-cleanliness in the tree, without me having to fix up all the drivers at once. Reviewed-by: Daniel Stone Reviewed-by: Kristian H. Kristensen Reviewed-by: Alyssa Rosenzweig Reviewed-by: Eric Engestrom Tested-by: Marge Bot Part-of: --- .gitlab-ci.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 90bb3b33fef..a403e5b2e64 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -466,6 +466,7 @@ meson-i386: -D vulkan-overlay-layer=true -D llvm=false -D osmesa=classic + -D werror=true meson-mingw32-x86_64: extends: .meson-build -- 2.30.2