From f741de236b5fa5522d8749a4b3e6d994fb98c630 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Wed, 14 Aug 2019 13:54:55 -0700 Subject: [PATCH] isl: Enable Unorm Path in Color Pipe Improves performance on my Icelake 8x8 locked to 700Mhz. For example, some GfxBench5 subtests have the following results: - [i965] gl_manhattan: ................ 7.01119% +/- 0.180971% (n=5) - [i965] gl_4 (Car Chase): 4.24351% +/- 0.175622% (n=5) - [i965] gl_blending: ................ 3.36327% +/- 0.180267% (n=5) - [i965] gl_5_normal (Aztec Ruins): 1.67962% +/- 0.243534% (n=10) - [iris] gl_manhattan: ................ 3.92357% +/- 0.073965% (n=25) - [iris] gl_4 (Car Chase): 2.17746% +/- 0.0826858% (n=5) - [iris] gl_blending: ................ 2.79599% +/- 0.803652% (n=15) - [iris] gl_5_normal (Aztec Ruins): 1.30930% +/- 0.106523% (n=25) Reviewed-by: Jason Ekstrand --- src/intel/genxml/gen11.xml | 1 + src/intel/isl/isl_surface_state.c | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/src/intel/genxml/gen11.xml b/src/intel/genxml/gen11.xml index e30143366f1..26c532b54bc 100644 --- a/src/intel/genxml/gen11.xml +++ b/src/intel/genxml/gen11.xml @@ -706,6 +706,7 @@ + diff --git a/src/intel/isl/isl_surface_state.c b/src/intel/isl/isl_surface_state.c index c47b8e0e9da..be9566d05c3 100644 --- a/src/intel/isl/isl_surface_state.c +++ b/src/intel/isl/isl_surface_state.c @@ -454,6 +454,10 @@ isl_genX(surf_fill_state_s)(const struct isl_device *dev, void *state, s.RenderCacheReadWriteMode = 0; #endif +#if GEN_GEN >= 11 + s.EnableUnormPathInColorPipe = true; +#endif + s.CubeFaceEnablePositiveZ = 1; s.CubeFaceEnableNegativeZ = 1; s.CubeFaceEnablePositiveY = 1; @@ -760,6 +764,10 @@ isl_genX(buffer_fill_state_s)(void *state, s.RenderCacheReadWriteMode = 0; #endif +#if GEN_GEN >= 11 + s.EnableUnormPathInColorPipe = true; +#endif + s.SurfaceBaseAddress = info->address; #if GEN_GEN >= 6 s.MOCS = info->mocs; -- 2.30.2