From f74cf04d3e81728591999b8ca952313178c54824 Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Wed, 28 Feb 2018 10:13:38 -0800 Subject: [PATCH] meson: Allow building dri based EGL without GLX It should be possible to build EGL without GLX, but the meson build currently doesn't allow that because it too tightly couples glx and dri. This patch eases dri and glx apart, so that EGL without GLX can be built. CC: Daniel Stone Reviewed-by: Eric Anholt Signed-off-by: Dylan Baker --- meson.build | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/meson.build b/meson.build index 8a17d7f240a..9950ac93b3b 100644 --- a/meson.build +++ b/meson.build @@ -1,4 +1,4 @@ -# Copyright © 2017 Intel Corporation +# Copyright © 2017-2018 Intel Corporation # Permission is hereby granted, free of charge, to any person obtaining a copy # of this software and associated documentation files (the "Software"), to deal @@ -29,6 +29,8 @@ project( default_options : ['buildtype=debugoptimized', 'c_std=c99', 'cpp_std=c++11'] ) +system_has_kms_drm = ['openbsd', 'netbsd', 'freebsd', 'dragonfly', 'linux'].contains(host_machine.system()) + # Arguments for the preprocessor, put these in a separate array from the C and # C++ (cpp in meson terminology) arguments since they need to be added to the # default arguments for both C and C++. @@ -172,6 +174,13 @@ if _drivers != '' with_gallium_virgl = _split.contains('virgl') with_gallium_swr = _split.contains('swr') with_gallium = true + if system_has_kms_drm + _glx = get_option('glx') + _egl = get_option('egl') + if _glx == 'dri' or _egl == 'true' or (_glx == 'disabled' and _egl != 'false') + with_dri = true + endif + endif endif with_intel_vk = false @@ -217,8 +226,6 @@ if with_dri_i915 or with_gallium_i915 dep_libdrm_intel = dependency('libdrm_intel', version : '>= 2.4.75') endif -system_has_kms_drm = ['openbsd', 'netbsd', 'freebsd', 'dragonfly', 'linux'].contains(host_machine.system()) - if host_machine.system() == 'darwin' with_dri_platform = 'apple' elif ['windows', 'cygwin'].contains(host_machine.system()) @@ -272,6 +279,7 @@ if with_glx == 'auto' elif with_gallium # Even when building just gallium drivers the user probably wants dri with_glx = 'dri' + with_dri = true elif with_platform_x11 and with_any_opengl and not with_any_vk # The automatic behavior should not be to turn on xlib based glx when # building only vulkan drivers @@ -280,11 +288,6 @@ if with_glx == 'auto' with_glx = 'disabled' endif endif -if with_glx == 'dri' - if with_gallium - with_dri = true - endif -endif if not (with_dri or with_gallium or with_glx == 'xlib' or with_glx == 'gallium-xlib') with_gles1 = false @@ -314,6 +317,8 @@ elif _egl == 'true' error('EGL requires shared-glapi') elif egl_native_platform == '' error('No platforms specified, consider -Dplatforms=drm,x11 at least') + elif not ['disabled', 'dri'].contains(with_glx) + error('EGL requires dri, but a GLX is being built without dri') endif with_egl = true else @@ -633,7 +638,7 @@ endif gl_pkgconfig_c_flags = [] if with_platform_x11 - if with_any_vk or (with_glx == 'dri' and with_dri_platform == 'drm') + if with_any_vk or with_egl or (with_glx == 'dri' and with_dri_platform == 'drm') pre_args += '-DHAVE_X11_PLATFORM' endif if with_glx == 'xlib' or with_glx == 'gallium-xlib' @@ -1219,7 +1224,7 @@ if with_platform_x11 dep_xcb = dependency('xcb') dep_x11_xcb = dependency('x11-xcb') endif - if with_any_vk or (with_glx == 'dri' and with_dri_platform == 'drm') + if with_any_vk or with_egl or (with_glx == 'dri' and with_dri_platform == 'drm') dep_xcb_dri2 = dependency('xcb-dri2', version : '>= 1.8') if with_dri3 -- 2.30.2