From f872fdbb5b83f39f359bc1cd016dcc0456cb0c0a Mon Sep 17 00:00:00 2001 From: Andrew Burgess Date: Thu, 10 Jan 2019 20:38:42 +0000 Subject: [PATCH] gdb/s12z: Use default gdbarch methods where possible Make use of the default gdbarch methods for gdbarch_unwind_pc, and gdbarch_unwind_sp where possible. I have not tested this change but, by inspecting the code, I believe the default methods are equivalent to the code being deleted. gdb/ChangeLog: * s12z-tdep.c (s12z_unwind_pc): Delete. (s12z_unwind_sp): Delete. (s12z_gdbarch_init): Don't register deleted functions with gdbarch. --- gdb/ChangeLog | 7 +++++++ gdb/s12z-tdep.c | 18 ------------------ 2 files changed, 7 insertions(+), 18 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 94f19981cbd..5c40683d3f6 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2019-04-23 Andrew Burgess + + * s12z-tdep.c (s12z_unwind_pc): Delete. + (s12z_unwind_sp): Delete. + (s12z_gdbarch_init): Don't register deleted functions with + gdbarch. + 2019-04-23 Andrew Burgess * rl78-tdep.c (rl78_unwind_sp): Delete. diff --git a/gdb/s12z-tdep.c b/gdb/s12z-tdep.c index ea14992b1c6..cef92d87743 100644 --- a/gdb/s12z-tdep.c +++ b/gdb/s12z-tdep.c @@ -95,20 +95,6 @@ s12z_skip_prologue (struct gdbarch *gdbarch, CORE_ADDR pc) return pc; } -/* Implement the unwind_pc gdbarch method. */ -static CORE_ADDR -s12z_unwind_pc (struct gdbarch *gdbarch, struct frame_info *next_frame) -{ - return frame_unwind_register_unsigned (next_frame, REG_P); -} - -/* Implement the unwind_sp gdbarch method. */ -static CORE_ADDR -s12z_unwind_sp (struct gdbarch *gdbarch, struct frame_info *next_frame) -{ - return frame_unwind_register_unsigned (next_frame, REG_S); -} - static struct type * s12z_register_type (struct gdbarch *gdbarch, int reg_nr) { @@ -581,10 +567,6 @@ s12z_gdbarch_init (struct gdbarch_info info, struct gdbarch_list *arches) set_gdbarch_register_type (gdbarch, s12z_register_type); - /* Functions to access frame data. */ - set_gdbarch_unwind_pc (gdbarch, s12z_unwind_pc); - set_gdbarch_unwind_sp (gdbarch, s12z_unwind_sp); - frame_unwind_append_unwinder (gdbarch, &s12z_frame_unwind); /* Currently, the only known producer for this archtecture, produces buggy dwarf CFI. So don't append a dwarf unwinder until the situation is -- 2.30.2