From f8904751117dc8d4d04e5c5286b71b854e6ebba5 Mon Sep 17 00:00:00 2001 From: Pedro Alves Date: Fri, 21 Aug 2015 23:49:37 +0100 Subject: [PATCH] C++: Initialize a couple const globals MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit In C++ mode, we get: src/gdb/gdbserver/tdesc.c:43:33: error: uninitialized const ‘default_description’ [-fpermissive] static const struct target_desc default_description; ^ In file included from src/gdb/gdbserver/tdesc.c:19:0: src/gdb/gdbserver/tdesc.h:26:8: note: ‘const struct target_desc’ has no user-provided default constructor struct target_desc ^ gdb/ChangeLog: 2015-08-21 Pedro Alves * frame.c (null_frame_id): Explicitly zero-initialize. gdb/gdbserver/ChangeLog: 2015-08-21 Pedro Alves * tdesc.c (default_description): Explicitly zero-initialize. --- gdb/ChangeLog | 4 ++++ gdb/frame.c | 2 +- gdb/gdbserver/ChangeLog | 4 ++++ gdb/gdbserver/tdesc.c | 2 +- 4 files changed, 10 insertions(+), 2 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index e99ec92543c..94bb7a515d0 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2015-08-21 Pedro Alves + + * frame.c (null_frame_id): Explicitly zero-initialize. + 2015-08-21 Tom Tromey * dwarf2read.c (struct dwarf2_section_info): Rename field diff --git a/gdb/frame.c b/gdb/frame.c index f05f7396766..745e0072e21 100644 --- a/gdb/frame.c +++ b/gdb/frame.c @@ -503,7 +503,7 @@ frame_unwind_caller_id (struct frame_info *next_frame) return null_frame_id; } -const struct frame_id null_frame_id; /* All zeros. */ +const struct frame_id null_frame_id = { 0 }; /* All zeros. */ const struct frame_id outer_frame_id = { 0, 0, 0, FID_STACK_INVALID, 0, 1, 0 }; struct frame_id diff --git a/gdb/gdbserver/ChangeLog b/gdb/gdbserver/ChangeLog index a11461ddb23..61032872c6a 100644 --- a/gdb/gdbserver/ChangeLog +++ b/gdb/gdbserver/ChangeLog @@ -1,3 +1,7 @@ +2015-08-21 Pedro Alves + + * tdesc.c (default_description): Explicitly zero-initialize. + 2015-08-21 Pedro Alves PR gdb/18749 diff --git a/gdb/gdbserver/tdesc.c b/gdb/gdbserver/tdesc.c index 8d008fd7e6e..1263efe4d7f 100644 --- a/gdb/gdbserver/tdesc.c +++ b/gdb/gdbserver/tdesc.c @@ -40,7 +40,7 @@ init_target_desc (struct target_desc *tdesc) #ifndef IN_PROCESS_AGENT -static const struct target_desc default_description; +static const struct target_desc default_description = { 0 }; void copy_target_description (struct target_desc *dest, -- 2.30.2