From f91e5ac34e150aeb5030c1005a510a231449c33c Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Fri, 8 Jan 2010 13:54:40 +0000 Subject: [PATCH] GDB crash with empty executable name (MinGW). * source.c (openp): Add assert that parameter string is not NULL. if parameter string is an empty string, then return with a failure immediately. --- gdb/ChangeLog | 7 +++++++ gdb/source.c | 14 ++++++++++++++ 2 files changed, 21 insertions(+) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 707b2f20be2..cb49ab9ddbf 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,10 @@ +2009-01-08 Joel Brobecker + + GDB crash with empty executable name (MinGW). + * source.c (openp): Add assert that parameter string is not NULL. + if parameter string is an empty string, then return with a failure + immediately. + 2009-01-08 Joel Brobecker Get rid of support for VAX Floats. diff --git a/gdb/source.c b/gdb/source.c index fcfce65a327..20903265716 100644 --- a/gdb/source.c +++ b/gdb/source.c @@ -707,6 +707,20 @@ openp (const char *path, int opts, const char *string, /* The open syscall MODE parameter is not specified. */ gdb_assert ((mode & O_CREAT) == 0); + gdb_assert (string != NULL); + + /* A file with an empty name cannot possibly exist. Report a failure + without further checking. + + This is an optimization which also defends us against buggy + implementations of the "stat" function. For instance, we have + noticed that a MinGW debugger built on Windows XP 32bits crashes + when the debugger is started with an empty argument. */ + if (string[0] == '\0') + { + errno = ENOENT; + return -1; + } if (!path) path = "."; -- 2.30.2