From f97b731c82afb06cfd6ffebc90a3e098a9a1b308 Mon Sep 17 00:00:00 2001 From: Roland Scheidegger Date: Wed, 17 Dec 2014 20:16:07 +0100 Subject: [PATCH] draw: revert using correct order for prim decomposition. This reverts db3dfcfe90a3d27e6020e0d3642f8ab0330e57be. The commit was correct but we've got some precision problems later in llvmpipe (or possibly in draw clip) due to the vertices coming in in different order, causing some internal test failures. So revert for now. (Will only affect drivers which actually support constant-interpolated attributes and not just flatshading.) --- src/gallium/auxiliary/draw/draw_pt_decompose.h | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/gallium/auxiliary/draw/draw_pt_decompose.h b/src/gallium/auxiliary/draw/draw_pt_decompose.h index 0b2522c08f0..c4fab6548b9 100644 --- a/src/gallium/auxiliary/draw/draw_pt_decompose.h +++ b/src/gallium/auxiliary/draw/draw_pt_decompose.h @@ -3,6 +3,8 @@ const boolean quads_flatshade_last = \ draw->quads_always_flatshade_last; \ const boolean last_vertex_last = \ - !draw->rasterizer->flatshade_first; + !(draw->rasterizer->flatshade && \ + draw->rasterizer->flatshade_first); +/* FIXME: the draw->rasterizer->flatshade part is really wrong */ #include "draw_decompose_tmp.h" -- 2.30.2