From f9e48344d54f45368a5e449fb2ccca70a723cd3a Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Fri, 28 Sep 2018 14:32:42 -0600 Subject: [PATCH] Use standard_output_file in a couple more places I noticed a few files left over in the testsuite/ directory in the build tree after running tests. Normally output files should not wind up there, but instead should end up in the test's subdirectory. This isn't always crucial, but in the past there were problems with tests clashing, preventing parallel runs, and so it is better to be clean here. This patch changes a couple of tests to use standard_output_file to fix this problem. Tested by re-running the tests in question and examining the directory. gdb/testsuite/ChangeLog 2018-10-06 Tom Tromey * gdb.base/gnu-ifunc.exp (build): Use standard_output_file. * gdb.trace/unavailable-dwarf-piece.exp: Use standard_output_file. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.base/gnu-ifunc.exp | 2 +- gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp | 2 +- 3 files changed, 7 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index fc37967390e..f43936b8094 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-10-06 Tom Tromey + + * gdb.base/gnu-ifunc.exp (build): Use standard_output_file. + * gdb.trace/unavailable-dwarf-piece.exp: Use standard_output_file. + 2018-10-06 Tom Tromey * gdb.python/py-breakpoint.exp (check_last_event): Check location diff --git a/gdb/testsuite/gdb.base/gnu-ifunc.exp b/gdb/testsuite/gdb.base/gnu-ifunc.exp index 322de5a6042..118ce4c1583 100644 --- a/gdb/testsuite/gdb.base/gnu-ifunc.exp +++ b/gdb/testsuite/gdb.base/gnu-ifunc.exp @@ -76,7 +76,7 @@ proc build {resolver_attr resolver_debug final_debug} { lappend final_opts "debug" } - set final_o $final_file-$suffix.o + set final_o [standard_output_file $final_file-$suffix.o] if { [gdb_compile_shlib ${srcdir}/${subdir}/$libsrc \ $lib_so $lib_opts] != "" diff --git a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp index 9fd3a739a70..49bfba8a05f 100644 --- a/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp +++ b/gdb/testsuite/gdb.trace/unavailable-dwarf-piece.exp @@ -22,7 +22,7 @@ if {![dwarf2_support]} { standard_testfile .c -set asm_file "${testfile}-dbg.s" +set asm_file [standard_output_file "${testfile}-dbg.s"] set opts {} if { [gdb_compile ${srcdir}/${subdir}/${srcfile} ${binfile}1.o \ -- 2.30.2