From fabe6a9a7a3154b2d03c7584847a48299ca1f042 Mon Sep 17 00:00:00 2001 From: Eric Botcazou Date: Tue, 8 Nov 2011 13:44:11 +0000 Subject: [PATCH] re PR rtl-optimization/47698 (CMOV accessing volatile memory with read side effect) PR rtl-optimization/47698 * ifcvt.c (noce_operand_ok): Move around comment. From-SVN: r181161 --- gcc/ChangeLog | 7 ++++++- gcc/ifcvt.c | 4 ++-- 2 files changed, 8 insertions(+), 3 deletions(-) diff --git a/gcc/ChangeLog b/gcc/ChangeLog index 6c92689892c..e5050e1248b 100644 --- a/gcc/ChangeLog +++ b/gcc/ChangeLog @@ -1,3 +1,8 @@ +2011-11-08 Eric Botcazou + + PR rtl-optimization/47698 + * ifcvt.c (noce_operand_ok): Move around comment. + 2011-11-08 Richard Guenther PR lto/50999 @@ -479,7 +484,7 @@ 2011-11-07 Sergey Ostanevich PR rtl-optimization/47698 - * ifconv.c (noce_operand_ok): prevent CMOV generation for volatile mem. + * ifcvt.c (noce_operand_ok): Return false for mems with side effects. 2011-11-07 Tristan Gingold diff --git a/gcc/ifcvt.c b/gcc/ifcvt.c index 3b05c2a8ad8..e8fa0bd0fb9 100644 --- a/gcc/ifcvt.c +++ b/gcc/ifcvt.c @@ -2327,11 +2327,11 @@ noce_get_condition (rtx jump, rtx *earliest, bool then_else_reversed) static int noce_operand_ok (const_rtx op) { - /* We special-case memories, so handle any of them with - no address side effects. */ if (side_effects_p (op)) return FALSE; + /* We special-case memories, so handle any of them with + no address side effects. */ if (MEM_P (op)) return ! side_effects_p (XEXP (op, 0)); -- 2.30.2