From fbb1d502eeae135dbe6ac3b0b122e574a9b888d6 Mon Sep 17 00:00:00 2001 From: Tom de Vries Date: Thu, 19 Jul 2018 16:24:16 +0200 Subject: [PATCH] [gdb/testsuite] Fix regexp in list-thread-groups-available.exp I ran into a gdb.mi/list-thread-groups-available.exp failure: ... Running gdb/testsuite/gdb.mi/list-thread-groups-available.exp ... FAIL: gdb.mi/list-thread-groups-available.exp: list available thread groups (unexpected output) PASS: gdb.mi/list-thread-groups-available.exp: list available thread groups with filter ... When doing an experiment of running it 100 times in a row, the failure reproduced 3 times. Analyzing the original failure led to insufficient quoting of square brackets in a regexp. This patch fixes the regexp, which resulted in 0 failures in a 100-in-a-row run. Tested on x86_64-linux. 2018-07-19 Tom de Vries * gdb.mi/list-thread-groups-available.exp (cores_re): Fix quoting in regular expression. --- gdb/testsuite/ChangeLog | 5 +++++ gdb/testsuite/gdb.mi/list-thread-groups-available.exp | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index dbd659d995a..79ef76faf76 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2018-07-19 Tom de Vries + + * gdb.mi/list-thread-groups-available.exp (cores_re): Fix quoting in + regular expression. + 2018-07-18 Tom de Vries * gdb.base/vla-optimized-out.c: New test. diff --git a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp index 7fd0ea223ab..c4dab2a2c34 100644 --- a/gdb/testsuite/gdb.mi/list-thread-groups-available.exp +++ b/gdb/testsuite/gdb.mi/list-thread-groups-available.exp @@ -45,7 +45,7 @@ set id_re "id=\"$decimal\"" set type_re "type=\"process\"" set description_re "description=\"$string_re\"" set user_re "user=\"$string_re\"" -set cores_re "cores=\[\"$decimal\"(,\"$decimal\")*\]" +set cores_re "cores=\\\[\"$decimal\"(,\"$decimal\")*\\\]" # List all available processes. set process_entry_re "{${id_re},${type_re}(,$description_re)?(,$user_re)?(,$cores_re)?}" -- 2.30.2