From fc49c92afc8478ed32ff4770d88b97081c7193d8 Mon Sep 17 00:00:00 2001 From: Peter Korsgaard Date: Wed, 4 Apr 2018 08:30:51 +0200 Subject: [PATCH] pkg-download.mk: do not add a trailing slash to _SITE Fixes http://autobuild.buildroot.net/results/734/7342b25f01d60cafc4a5422a5a1c282629f361c5/ $(dir does not strip last path separator and the wget wrapper adds a '/' between the -u argument and the filename when it reconstructs the URL, leading us to have two slashes before the filename when accessing the upstream location. Most upstream servers ignores this, but not all - Leading to download issues from pypi. Notice: As pointed out by Arnout, we cannot simply use $(PKG)_SITE here as _PATCH and _EXTRA_DOWNLOADS may contain full URLs. Signed-off-by: Peter Korsgaard --- package/pkg-download.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/pkg-download.mk b/package/pkg-download.mk index 7ed95f2b2c..2c4ad3ba2c 100644 --- a/package/pkg-download.mk +++ b/package/pkg-download.mk @@ -82,7 +82,7 @@ endif ifeq ($(BR2_PRIMARY_SITE_ONLY),) DOWNLOAD_URIS += \ - -u $($(PKG)_SITE_METHOD)+$(dir $(call qstrip,$(1))) + -u $($(PKG)_SITE_METHOD)+$(patsubst %/,%,$(dir $(call qstrip,$(1)))) ifneq ($(call qstrip,$(BR2_BACKUP_SITE)),) DOWNLOAD_URIS += \ -u $(call getschemeplusuri,$(call qstrip,$(BR2_BACKUP_SITE)/$($(PKG)_DL_SUBDIR)),urlencode) \ -- 2.30.2