From fd0324a1ce9af727442a4a7208f0c017cdd7c681 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Wed, 27 May 2020 11:33:26 -0400 Subject: [PATCH] pan/bi: Document compute_lod bit for compact tex At least I assume this works this way. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/bifrost/disassemble.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/src/panfrost/bifrost/disassemble.c b/src/panfrost/bifrost/disassemble.c index 5ed1d309f08..debc710b3be 100644 --- a/src/panfrost/bifrost/disassemble.c +++ b/src/panfrost/bifrost/disassemble.c @@ -1430,10 +1430,9 @@ static void dump_add(FILE *fp, uint64_t word, struct bifrost_regs regs, if (info.src_type == ADD_TEX_COMPACT) { tex_index = (ADD.op >> 3) & 0x7; sampler_index = (ADD.op >> 7) & 0x7; - bool unknown = (ADD.op & 0x40); - // TODO: figure out if the unknown bit is ever 0 - if (!unknown) - fprintf(fp, "unknown "); + bool compute_lod = (ADD.op & 0x40); + if (!compute_lod) + fprintf(fp, "vtx lod 0 "); } else { uint64_t constVal = get_const(consts, regs); uint32_t controlBits = (ADD.op & 0x8) ? (constVal >> 32) : constVal; -- 2.30.2