From fe56157f92879313e0a6f46eeaee06f71314cc04 Mon Sep 17 00:00:00 2001 From: Tom Tromey Date: Thu, 5 Dec 2019 07:58:03 -0700 Subject: [PATCH] Remove ATTRIBUTE_UNUSED check from ARI The text for the ATTRIBUTE_UNUSED check in ARI is plainly incorrect now -- gdb does in fact use ATTRIBUTE_UNUSED, and there's no issue in doing so, when done properly. This patch removes this check. gdb/ChangeLog 2019-12-13 Tom Tromey * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check. Change-Id: I13fd8e9b40dbaab3978dbf9b6c4228b62299d944 --- gdb/ChangeLog | 4 ++++ gdb/contrib/ari/gdb_ari.sh | 11 ----------- 2 files changed, 4 insertions(+), 11 deletions(-) diff --git a/gdb/ChangeLog b/gdb/ChangeLog index fea37ae26ee..6755a105ed1 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,7 @@ +2019-12-13 Tom Tromey + + * contrib/ari/gdb_ari.sh: Remove ATTRIBUTE_UNUSED check. + 2019-12-13 Tom Tromey * contrib/ari/gdb_ari.sh: Remove "boolean" and "var_boolean" diff --git a/gdb/contrib/ari/gdb_ari.sh b/gdb/contrib/ari/gdb_ari.sh index ee9f16a8ddd..b5a54334dac 100755 --- a/gdb/contrib/ari/gdb_ari.sh +++ b/gdb/contrib/ari/gdb_ari.sh @@ -581,17 +581,6 @@ Do not use `long long'\'', instead use LONGEST" fail("long long") } -BEGIN { doc["ATTRIBUTE_UNUSED"] = "\ -Do not use ATTRIBUTE_UNUSED, do not bother (GDB is compiled with -Werror and, \ -consequently, is not able to tolerate false warnings. Since -Wunused-param \ -produces such warnings, neither that warning flag nor ATTRIBUTE_UNUSED \ -are used by GDB" - category["ATTRIBUTE_UNUSED"] = ari_regression -} -/(^|[^_[:alnum:]])ATTRIBUTE_UNUSED([^_[:alnum:]]|$)/ { - fail("ATTRIBUTE_UNUSED") -} - BEGIN { doc["ATTR_FORMAT"] = "\ Do not use ATTR_FORMAT, use ATTRIBUTE_PRINTF instead" category["ATTR_FORMAT"] = ari_regression -- 2.30.2