From fe7fab4be55983fa8abc0172393afea8b0fed416 Mon Sep 17 00:00:00 2001 From: Kenneth Graunke Date: Tue, 10 Oct 2017 10:19:21 -0700 Subject: [PATCH] i965: Drop brw_bo_alloc in ARB_indirect_parameters implementation. The original implementation allocated a new BO here, but we decided to switch to intel_upload_space, which returns a reference to the current upload BO. We accidentally kept the brw_bo_alloc, even though it's no longer necessary - intel_upload_space will immediately unreference it, causing us to allocate and immediately free a buffer. Reviewed-by: Plamena Manolova --- src/mesa/drivers/dri/i965/brw_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/mesa/drivers/dri/i965/brw_draw.c b/src/mesa/drivers/dri/i965/brw_draw.c index d6aa95b6f60..0364d442f21 100644 --- a/src/mesa/drivers/dri/i965/brw_draw.c +++ b/src/mesa/drivers/dri/i965/brw_draw.c @@ -903,7 +903,7 @@ brw_draw_prims(struct gl_context *ctx, for (i = 0; i < nr_prims; i++) { /* Implementation of ARB_indirect_parameters via predicates */ if (brw->draw.draw_params_count_bo) { - struct brw_bo *draw_id_bo = brw_bo_alloc(brw->bufmgr, "draw_id", 4, 4); + struct brw_bo *draw_id_bo = NULL; uint32_t draw_id_offset; intel_upload_data(brw, &prims[i].draw_id, 4, 4, &draw_id_bo, -- 2.30.2