From ff87b8ad52145045bc3f4d1082204d962d7c3dd5 Mon Sep 17 00:00:00 2001 From: Jose Marinho Date: Tue, 13 Jun 2017 15:21:22 +0100 Subject: [PATCH] sim: Fix clashing stat names in TickedObject and Ticked Change tickCycles numCycles stat name to totalTickCycles os as not to clash with the name of the tickCycles stat of the same class. Declared the params passed to the TickedObject constructer as const. Call ClockedObject::regStats() from the TickedObject::regStats to ensure the correct initialization of the base class (ClockedObject) stats Change-Id: I6cf5bbe10fa27f2ad0e31d9f70ec3be47fe41455 Signed-off-by: Andreas Sandberg Reviewed-on: https://gem5-review.googlesource.com/3964 Reviewed-by: Jason Lowe-Power Maintainer: Jason Lowe-Power --- src/sim/ticked_object.cc | 7 ++++--- src/sim/ticked_object.hh | 4 ++-- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/src/sim/ticked_object.cc b/src/sim/ticked_object.cc index 4cd0dc171..a9f3aceb7 100644 --- a/src/sim/ticked_object.cc +++ b/src/sim/ticked_object.cc @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013-2014 ARM Limited + * Copyright (c) 2013-2014, 2017 ARM Limited * All rights reserved * * The license below extends only to copyright in the software and shall @@ -60,7 +60,7 @@ Ticked::regStats() { if (numCyclesLocal) { numCycles - .name(object.name() + ".tickCycles") + .name(object.name() + ".totalTickCycles") .desc("Number of cycles that the object ticked or was stopped"); } @@ -98,7 +98,7 @@ Ticked::unserialize(CheckpointIn &cp) lastStopped = Cycles(lastStoppedUint); } -TickedObject::TickedObject(TickedObjectParams *params, +TickedObject::TickedObject(const TickedObjectParams *params, Event::Priority priority) : ClockedObject(params), /* Make numCycles in Ticked */ @@ -109,6 +109,7 @@ void TickedObject::regStats() { Ticked::regStats(); + ClockedObject::regStats(); } void diff --git a/src/sim/ticked_object.hh b/src/sim/ticked_object.hh index d8b69a320..3ba0045fc 100644 --- a/src/sim/ticked_object.hh +++ b/src/sim/ticked_object.hh @@ -1,5 +1,5 @@ /* - * Copyright (c) 2013-2014 ARM Limited + * Copyright (c) 2013-2014, 2017 ARM Limited * All rights reserved * * The license below extends only to copyright in the software and shall @@ -190,7 +190,7 @@ class Ticked : public Serializable class TickedObject : public ClockedObject, public Ticked { public: - TickedObject(TickedObjectParams *params, + TickedObject(const TickedObjectParams *params, Event::Priority priority = Event::CPU_Tick_Pri); /** Disambiguate to make these functions overload correctly */ -- 2.30.2