misc: Update CONTRIBUTING with gerrit changes
authorJason Lowe-Power <jason@lowepower.com>
Thu, 26 Jul 2018 18:59:39 +0000 (11:59 -0700)
committerJason Lowe-Power <jason@lowepower.com>
Fri, 27 Jul 2018 15:41:14 +0000 (15:41 +0000)
Change-Id: I39b5a784a056195a5e71fd21b3abb5fc91ab70e7
Signed-off-by: Jason Lowe-Power <jason@lowepower.com>
Reviewed-on: https://gem5-review.googlesource.com/11872

CONTRIBUTING.md

index 3cfad9f789e7ce4fe60724d26551bf483ec00620..92d8ea8c48d1484a83a3b344f57594ae223b5429 100644 (file)
@@ -244,13 +244,21 @@ changeset.
  git commit --amend
 ```
 
-Push change to gerrit as a draft
---------------------------------
+Push change to gerrit as a draft/private
+----------------------------------------
+
+See https://gerrit-review.googlesource.com/Documentation/intro-user.html#private-changes
+for details on private gerrit changes.
 
 ```
- git push origin HEAD:refs/drafts/master
+ git push origin HEAD:refs/for/master%private
 ```
 
+Once you have pushed your change as "private", you can log onto [gerrit]
+(https://gem5-review.googlesource.com) and once you're happy with the commit
+click the "unmark private" which may be hidden in the "more options" dropdown
+in the upper right corner.
+
 Push change bypassing gerrit
 -----------------------------