tests: Fix python line break in m5_exit test
authorGiacomo Travaglini <giacomo.travaglini@arm.com>
Tue, 21 Jan 2020 10:32:52 +0000 (10:32 +0000)
committerGiacomo Travaglini <giacomo.travaglini@arm.com>
Wed, 22 Jan 2020 11:12:52 +0000 (11:12 +0000)
A bug has been introduced with the new test url.
The line break should have used a backslash or (this is the recommended
way by PEP8) the implied line continuation via parenthesis.
This error was preventing the test to be loaded with the error message:

Exception thrown while loading
"/tmpfs/src/git/jenkins-gem5-prod/tests/gem5/m5_util/test_exit.py"
Ignoring all tests in this file.

and was not producing a failure (the test was not run: it was jus
ignored).

Change-Id: I0afe252d66d2f6546caaf5e7be811f34f88df82c
Signed-off-by: Giacomo Travaglini <giacomo.travaglini@arm.com>
Reviewed-by: Ciro Santilli <ciro.santilli@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/24625
Reviewed-by: Jason Lowe-Power <jason@lowepower.com>
Maintainer: Jason Lowe-Power <jason@lowepower.com>
Tested-by: kokoro <noreply+kokoro@google.com>
tests/gem5/m5_util/test_exit.py

index e67e37428b3c1cdbb5afbc7ae78c4eebd45bcdcf..42f4215fcaa5d9f1517f24d066f1f8c9ac6d0861 100644 (file)
@@ -55,8 +55,8 @@ else:
     path = joinpath(absdirpath(__file__), '..',
                     'test-progs', 'hello', 'bin', 'x86', 'linux')
 filename = 'm5_exit'
-url = 'http://dist.gem5.org/dist/current/test-progs/' +
-      'm5-exit/bin/x86/linux/m5_exit'
+url = ('http://dist.gem5.org/dist/current/test-progs/' +
+       'm5-exit/bin/x86/linux/m5_exit')
 test_program = DownloadedProgram(url, path, filename)
 
 a = verifier.MatchRegex(m5_exit_regex)