2 * Copyright © 2014 Intel Corporation
4 * Permission is hereby granted, free of charge, to any person obtaining a
5 * copy of this software and associated documentation files (the "Software"),
6 * to deal in the Software without restriction, including without limitation
7 * the rights to use, copy, modify, merge, publish, distribute, sublicense,
8 * and/or sell copies of the Software, and to permit persons to whom the
9 * Software is furnished to do so, subject to the following conditions:
11 * The above copyright notice and this permission notice (including the next
12 * paragraph) shall be included in all copies or substantial portions of the
15 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
18 * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
20 * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
24 * Connor Abbott (cwabbott0@gmail.com)
29 #include "c11/threads.h"
33 * This file checks for invalid IR indicating a bug somewhere in the compiler.
36 /* Since this file is just a pile of asserts, don't bother compiling it if
37 * we're not building a debug build.
42 * Per-register validation state.
47 * equivalent to the uses and defs in nir_register, but built up by the
48 * validator. At the end, we verify that the sets have the same entries.
50 struct set
*uses
, *if_uses
, *defs
;
51 nir_function_impl
*where_defined
; /* NULL for global registers */
57 /* map of register -> validation state (struct above) */
58 struct hash_table
*regs
;
60 /* the current shader being validated */
63 /* the current instruction being validated */
66 /* the current variable being validated */
69 /* the current basic block being validated */
72 /* the current if statement being validated */
75 /* the current loop being visited */
78 /* the parent of the current cf node being visited */
79 nir_cf_node
*parent_node
;
81 /* the current function implementation being validated */
82 nir_function_impl
*impl
;
84 /* Set of seen SSA sources */
87 /* bitset of ssa definitions we have found; used to check uniqueness */
88 BITSET_WORD
*ssa_defs_found
;
90 /* bitset of registers we have currently found; used to check uniqueness */
91 BITSET_WORD
*regs_found
;
93 /* map of variable -> function implementation where it is defined or NULL
94 * if it is a global variable
96 struct hash_table
*var_defs
;
98 /* map of instruction/var/etc to failed assert string */
99 struct hash_table
*errors
;
103 log_error(validate_state
*state
, const char *cond
, const char *file
, int line
)
114 char *msg
= ralloc_asprintf(state
->errors
, "error: %s (%s:%d)",
117 _mesa_hash_table_insert(state
->errors
, obj
, msg
);
120 #define validate_assert(state, cond) do { \
122 log_error(state, #cond, __FILE__, __LINE__); \
125 static void validate_src(nir_src
*src
, validate_state
*state
,
126 unsigned bit_sizes
, unsigned num_components
);
129 validate_num_components(validate_state
*state
, unsigned num_components
)
131 validate_assert(state
, nir_num_components_valid(num_components
));
135 validate_reg_src(nir_src
*src
, validate_state
*state
,
136 unsigned bit_sizes
, unsigned num_components
)
138 validate_assert(state
, src
->reg
.reg
!= NULL
);
140 struct hash_entry
*entry
;
141 entry
= _mesa_hash_table_search(state
->regs
, src
->reg
.reg
);
142 validate_assert(state
, entry
);
144 reg_validate_state
*reg_state
= (reg_validate_state
*) entry
->data
;
147 _mesa_set_add(reg_state
->uses
, src
);
149 validate_assert(state
, state
->if_stmt
);
150 _mesa_set_add(reg_state
->if_uses
, src
);
153 validate_assert(state
, reg_state
->where_defined
== state
->impl
&&
154 "using a register declared in a different function");
157 validate_assert(state
, src
->reg
.reg
->bit_size
& bit_sizes
);
159 validate_assert(state
, src
->reg
.reg
->num_components
== num_components
);
161 validate_assert(state
, (src
->reg
.reg
->num_array_elems
== 0 ||
162 src
->reg
.base_offset
< src
->reg
.reg
->num_array_elems
) &&
163 "definitely out-of-bounds array access");
165 if (src
->reg
.indirect
) {
166 validate_assert(state
, src
->reg
.reg
->num_array_elems
!= 0);
167 validate_assert(state
, (src
->reg
.indirect
->is_ssa
||
168 src
->reg
.indirect
->reg
.indirect
== NULL
) &&
169 "only one level of indirection allowed");
170 validate_src(src
->reg
.indirect
, state
, 32, 1);
174 #define SET_PTR_BIT(ptr, bit) \
175 (void *)(((uintptr_t)(ptr)) | (((uintptr_t)1) << bit))
178 validate_ssa_src(nir_src
*src
, validate_state
*state
,
179 unsigned bit_sizes
, unsigned num_components
)
181 validate_assert(state
, src
->ssa
!= NULL
);
183 /* As we walk SSA defs, we add every use to this set. We need to make sure
184 * our use is seen in a use list.
186 struct set_entry
*entry
;
188 entry
= _mesa_set_search(state
->ssa_srcs
, src
);
190 entry
= _mesa_set_search(state
->ssa_srcs
, SET_PTR_BIT(src
, 0));
192 validate_assert(state
, entry
);
194 /* This will let us prove that we've seen all the sources */
196 _mesa_set_remove(state
->ssa_srcs
, entry
);
199 validate_assert(state
, src
->ssa
->bit_size
& bit_sizes
);
201 validate_assert(state
, src
->ssa
->num_components
== num_components
);
203 /* TODO validate that the use is dominated by the definition */
207 validate_src(nir_src
*src
, validate_state
*state
,
208 unsigned bit_sizes
, unsigned num_components
)
211 validate_assert(state
, src
->parent_instr
== state
->instr
);
213 validate_assert(state
, src
->parent_if
== state
->if_stmt
);
216 validate_ssa_src(src
, state
, bit_sizes
, num_components
);
218 validate_reg_src(src
, state
, bit_sizes
, num_components
);
222 validate_alu_src(nir_alu_instr
*instr
, unsigned index
, validate_state
*state
)
224 nir_alu_src
*src
= &instr
->src
[index
];
226 if (instr
->op
== nir_op_mov
)
227 assert(!src
->abs
&& !src
->negate
);
229 unsigned num_components
= nir_src_num_components(src
->src
);
230 for (unsigned i
= 0; i
< NIR_MAX_VEC_COMPONENTS
; i
++) {
231 validate_assert(state
, src
->swizzle
[i
] < NIR_MAX_VEC_COMPONENTS
);
233 if (nir_alu_instr_channel_used(instr
, index
, i
))
234 validate_assert(state
, src
->swizzle
[i
] < num_components
);
237 validate_src(&src
->src
, state
, 0, 0);
241 validate_reg_dest(nir_reg_dest
*dest
, validate_state
*state
,
242 unsigned bit_sizes
, unsigned num_components
)
244 validate_assert(state
, dest
->reg
!= NULL
);
246 validate_assert(state
, dest
->parent_instr
== state
->instr
);
248 struct hash_entry
*entry2
;
249 entry2
= _mesa_hash_table_search(state
->regs
, dest
->reg
);
251 validate_assert(state
, entry2
);
253 reg_validate_state
*reg_state
= (reg_validate_state
*) entry2
->data
;
254 _mesa_set_add(reg_state
->defs
, dest
);
256 validate_assert(state
, reg_state
->where_defined
== state
->impl
&&
257 "writing to a register declared in a different function");
260 validate_assert(state
, dest
->reg
->bit_size
& bit_sizes
);
262 validate_assert(state
, dest
->reg
->num_components
== num_components
);
264 validate_assert(state
, (dest
->reg
->num_array_elems
== 0 ||
265 dest
->base_offset
< dest
->reg
->num_array_elems
) &&
266 "definitely out-of-bounds array access");
268 if (dest
->indirect
) {
269 validate_assert(state
, dest
->reg
->num_array_elems
!= 0);
270 validate_assert(state
, (dest
->indirect
->is_ssa
|| dest
->indirect
->reg
.indirect
== NULL
) &&
271 "only one level of indirection allowed");
272 validate_src(dest
->indirect
, state
, 32, 1);
277 validate_ssa_def(nir_ssa_def
*def
, validate_state
*state
)
279 validate_assert(state
, def
->index
< state
->impl
->ssa_alloc
);
280 validate_assert(state
, !BITSET_TEST(state
->ssa_defs_found
, def
->index
));
281 BITSET_SET(state
->ssa_defs_found
, def
->index
);
283 validate_assert(state
, def
->parent_instr
== state
->instr
);
284 validate_num_components(state
, def
->num_components
);
286 list_validate(&def
->uses
);
287 nir_foreach_use(src
, def
) {
288 validate_assert(state
, src
->is_ssa
);
289 validate_assert(state
, src
->ssa
== def
);
290 bool already_seen
= false;
291 _mesa_set_search_and_add(state
->ssa_srcs
, src
, &already_seen
);
292 /* A nir_src should only appear once and only in one SSA def use list */
293 validate_assert(state
, !already_seen
);
296 list_validate(&def
->if_uses
);
297 nir_foreach_if_use(src
, def
) {
298 validate_assert(state
, src
->is_ssa
);
299 validate_assert(state
, src
->ssa
== def
);
300 bool already_seen
= false;
301 _mesa_set_search_and_add(state
->ssa_srcs
, SET_PTR_BIT(src
, 0),
303 /* A nir_src should only appear once and only in one SSA def use list */
304 validate_assert(state
, !already_seen
);
309 validate_dest(nir_dest
*dest
, validate_state
*state
,
310 unsigned bit_sizes
, unsigned num_components
)
314 validate_assert(state
, dest
->ssa
.bit_size
& bit_sizes
);
316 validate_assert(state
, dest
->ssa
.num_components
== num_components
);
317 validate_ssa_def(&dest
->ssa
, state
);
319 validate_reg_dest(&dest
->reg
, state
, bit_sizes
, num_components
);
324 validate_alu_dest(nir_alu_instr
*instr
, validate_state
*state
)
326 nir_alu_dest
*dest
= &instr
->dest
;
328 if (instr
->op
== nir_op_mov
)
329 assert(!dest
->saturate
);
331 unsigned dest_size
= nir_dest_num_components(dest
->dest
);
333 * validate that the instruction doesn't write to components not in the
336 validate_assert(state
, !(dest
->write_mask
& ~((1 << dest_size
) - 1)));
338 /* validate that saturate is only ever used on instructions with
339 * destinations of type float
341 nir_alu_instr
*alu
= nir_instr_as_alu(state
->instr
);
342 validate_assert(state
,
343 (nir_alu_type_get_base_type(nir_op_infos
[alu
->op
].output_type
) ==
347 validate_dest(&dest
->dest
, state
, 0, 0);
351 validate_alu_instr(nir_alu_instr
*instr
, validate_state
*state
)
353 validate_assert(state
, instr
->op
< nir_num_opcodes
);
355 unsigned instr_bit_size
= 0;
356 for (unsigned i
= 0; i
< nir_op_infos
[instr
->op
].num_inputs
; i
++) {
357 nir_alu_type src_type
= nir_op_infos
[instr
->op
].input_types
[i
];
358 unsigned src_bit_size
= nir_src_bit_size(instr
->src
[i
].src
);
359 if (nir_alu_type_get_type_size(src_type
)) {
360 validate_assert(state
, src_bit_size
== nir_alu_type_get_type_size(src_type
));
361 } else if (instr_bit_size
) {
362 validate_assert(state
, src_bit_size
== instr_bit_size
);
364 instr_bit_size
= src_bit_size
;
367 if (nir_alu_type_get_base_type(src_type
) == nir_type_float
) {
368 /* 8-bit float isn't a thing */
369 validate_assert(state
, src_bit_size
== 16 || src_bit_size
== 32 ||
373 validate_alu_src(instr
, i
, state
);
376 nir_alu_type dest_type
= nir_op_infos
[instr
->op
].output_type
;
377 unsigned dest_bit_size
= nir_dest_bit_size(instr
->dest
.dest
);
378 if (nir_alu_type_get_type_size(dest_type
)) {
379 validate_assert(state
, dest_bit_size
== nir_alu_type_get_type_size(dest_type
));
380 } else if (instr_bit_size
) {
381 validate_assert(state
, dest_bit_size
== instr_bit_size
);
383 /* The only unsized thing is the destination so it's vacuously valid */
386 if (nir_alu_type_get_base_type(dest_type
) == nir_type_float
) {
387 /* 8-bit float isn't a thing */
388 validate_assert(state
, dest_bit_size
== 16 || dest_bit_size
== 32 ||
389 dest_bit_size
== 64);
392 validate_alu_dest(instr
, state
);
396 validate_var_use(nir_variable
*var
, validate_state
*state
)
398 struct hash_entry
*entry
= _mesa_hash_table_search(state
->var_defs
, var
);
399 validate_assert(state
, entry
);
400 if (entry
&& var
->data
.mode
== nir_var_function_temp
)
401 validate_assert(state
, (nir_function_impl
*) entry
->data
== state
->impl
);
405 validate_deref_instr(nir_deref_instr
*instr
, validate_state
*state
)
407 if (instr
->deref_type
== nir_deref_type_var
) {
408 /* Variable dereferences are stupid simple. */
409 validate_assert(state
, instr
->mode
== instr
->var
->data
.mode
);
410 validate_assert(state
, instr
->type
== instr
->var
->type
);
411 validate_var_use(instr
->var
, state
);
412 } else if (instr
->deref_type
== nir_deref_type_cast
) {
413 /* For cast, we simply have to trust the instruction. It's up to
414 * lowering passes and front/back-ends to make them sane.
416 validate_src(&instr
->parent
, state
, 0, 0);
418 /* We just validate that the type and mode are there */
419 validate_assert(state
, instr
->mode
);
420 validate_assert(state
, instr
->type
);
422 /* We require the parent to be SSA. This may be lifted in the future */
423 validate_assert(state
, instr
->parent
.is_ssa
);
425 /* The parent pointer value must have the same number of components
426 * as the destination.
428 validate_src(&instr
->parent
, state
, nir_dest_bit_size(instr
->dest
),
429 nir_dest_num_components(instr
->dest
));
431 nir_instr
*parent_instr
= instr
->parent
.ssa
->parent_instr
;
433 /* The parent must come from another deref instruction */
434 validate_assert(state
, parent_instr
->type
== nir_instr_type_deref
);
436 nir_deref_instr
*parent
= nir_instr_as_deref(parent_instr
);
438 validate_assert(state
, instr
->mode
== parent
->mode
);
440 switch (instr
->deref_type
) {
441 case nir_deref_type_struct
:
442 validate_assert(state
, glsl_type_is_struct_or_ifc(parent
->type
));
443 validate_assert(state
,
444 instr
->strct
.index
< glsl_get_length(parent
->type
));
445 validate_assert(state
, instr
->type
==
446 glsl_get_struct_field(parent
->type
, instr
->strct
.index
));
449 case nir_deref_type_array
:
450 case nir_deref_type_array_wildcard
:
451 if (instr
->mode
== nir_var_mem_ubo
||
452 instr
->mode
== nir_var_mem_ssbo
||
453 instr
->mode
== nir_var_mem_shared
||
454 instr
->mode
== nir_var_mem_global
) {
455 /* Shared variables and UBO/SSBOs have a bit more relaxed rules
456 * because we need to be able to handle array derefs on vectors.
457 * Fortunately, nir_lower_io handles these just fine.
459 validate_assert(state
, glsl_type_is_array(parent
->type
) ||
460 glsl_type_is_matrix(parent
->type
) ||
461 glsl_type_is_vector(parent
->type
));
463 /* Most of NIR cannot handle array derefs on vectors */
464 validate_assert(state
, glsl_type_is_array(parent
->type
) ||
465 glsl_type_is_matrix(parent
->type
));
467 validate_assert(state
,
468 instr
->type
== glsl_get_array_element(parent
->type
));
470 if (instr
->deref_type
== nir_deref_type_array
) {
471 validate_src(&instr
->arr
.index
, state
,
472 nir_dest_bit_size(instr
->dest
), 1);
476 case nir_deref_type_ptr_as_array
:
477 /* ptr_as_array derefs must have a parent that is either an array,
478 * ptr_as_array, or cast. If the parent is a cast, we get the stride
479 * information (if any) from the cast deref.
481 validate_assert(state
,
482 parent
->deref_type
== nir_deref_type_array
||
483 parent
->deref_type
== nir_deref_type_ptr_as_array
||
484 parent
->deref_type
== nir_deref_type_cast
);
485 validate_assert(state
, nir_deref_instr_ptr_as_array_stride(parent
));
486 validate_src(&instr
->arr
.index
, state
,
487 nir_dest_bit_size(instr
->dest
), 1);
491 unreachable("Invalid deref instruction type");
495 /* We intentionally don't validate the size of the destination because we
496 * want to let other compiler components such as SPIR-V decide how big
497 * pointers should be.
499 validate_dest(&instr
->dest
, state
, 0, 0);
501 /* Deref instructions as if conditions don't make sense because if
502 * conditions expect well-formed Booleans. If you want to compare with
503 * NULL, an explicit comparison operation should be used.
505 validate_assert(state
, list_is_empty(&instr
->dest
.ssa
.if_uses
));
507 /* Only certain modes can be used as sources for phi instructions. */
508 nir_foreach_use(use
, &instr
->dest
.ssa
) {
509 if (use
->parent_instr
->type
== nir_instr_type_phi
) {
510 validate_assert(state
, instr
->mode
== nir_var_mem_ubo
||
511 instr
->mode
== nir_var_mem_ssbo
||
512 instr
->mode
== nir_var_mem_shared
||
513 instr
->mode
== nir_var_mem_global
);
519 validate_intrinsic_instr(nir_intrinsic_instr
*instr
, validate_state
*state
)
521 unsigned dest_bit_size
= 0;
522 unsigned src_bit_sizes
[NIR_INTRINSIC_MAX_INPUTS
] = { 0, };
523 switch (instr
->intrinsic
) {
524 case nir_intrinsic_load_param
: {
525 unsigned param_idx
= nir_intrinsic_param_idx(instr
);
526 validate_assert(state
, param_idx
< state
->impl
->function
->num_params
);
527 nir_parameter
*param
= &state
->impl
->function
->params
[param_idx
];
528 validate_assert(state
, instr
->num_components
== param
->num_components
);
529 dest_bit_size
= param
->bit_size
;
533 case nir_intrinsic_load_deref
: {
534 nir_deref_instr
*src
= nir_src_as_deref(instr
->src
[0]);
536 validate_assert(state
, glsl_type_is_vector_or_scalar(src
->type
) ||
537 (src
->mode
== nir_var_uniform
&&
538 glsl_get_base_type(src
->type
) == GLSL_TYPE_SUBROUTINE
));
539 validate_assert(state
, instr
->num_components
==
540 glsl_get_vector_elements(src
->type
));
541 dest_bit_size
= glsl_get_bit_size(src
->type
);
542 /* Also allow 32-bit boolean load operations */
543 if (glsl_type_is_boolean(src
->type
))
548 case nir_intrinsic_store_deref
: {
549 nir_deref_instr
*dst
= nir_src_as_deref(instr
->src
[0]);
551 validate_assert(state
, glsl_type_is_vector_or_scalar(dst
->type
));
552 validate_assert(state
, instr
->num_components
==
553 glsl_get_vector_elements(dst
->type
));
554 src_bit_sizes
[1] = glsl_get_bit_size(dst
->type
);
555 /* Also allow 32-bit boolean store operations */
556 if (glsl_type_is_boolean(dst
->type
))
557 src_bit_sizes
[1] |= 32;
558 validate_assert(state
, (dst
->mode
& (nir_var_shader_in
|
559 nir_var_uniform
)) == 0);
560 validate_assert(state
, (nir_intrinsic_write_mask(instr
) & ~((1 << instr
->num_components
) - 1)) == 0);
564 case nir_intrinsic_copy_deref
: {
565 nir_deref_instr
*dst
= nir_src_as_deref(instr
->src
[0]);
566 nir_deref_instr
*src
= nir_src_as_deref(instr
->src
[1]);
567 validate_assert(state
, glsl_get_bare_type(dst
->type
) ==
568 glsl_get_bare_type(src
->type
));
569 validate_assert(state
, (dst
->mode
& (nir_var_shader_in
|
570 nir_var_uniform
)) == 0);
574 case nir_intrinsic_load_ubo
:
575 case nir_intrinsic_load_ssbo
:
576 case nir_intrinsic_load_shared
:
577 case nir_intrinsic_load_global
:
578 case nir_intrinsic_load_scratch
:
579 case nir_intrinsic_load_constant
:
580 /* These memory load operations must have alignments */
581 validate_assert(state
,
582 util_is_power_of_two_nonzero(nir_intrinsic_align_mul(instr
)));
583 validate_assert(state
, nir_intrinsic_align_offset(instr
) <
584 nir_intrinsic_align_mul(instr
));
587 case nir_intrinsic_load_uniform
:
588 case nir_intrinsic_load_input
:
589 case nir_intrinsic_load_per_vertex_input
:
590 case nir_intrinsic_load_interpolated_input
:
591 case nir_intrinsic_load_output
:
592 case nir_intrinsic_load_per_vertex_output
:
593 case nir_intrinsic_load_push_constant
:
594 /* All memory load operations must load at least a byte */
595 validate_assert(state
, nir_dest_bit_size(instr
->dest
) >= 8);
598 case nir_intrinsic_store_ssbo
:
599 case nir_intrinsic_store_shared
:
600 case nir_intrinsic_store_global
:
601 case nir_intrinsic_store_scratch
:
602 /* These memory store operations must also have alignments */
603 validate_assert(state
,
604 util_is_power_of_two_nonzero(nir_intrinsic_align_mul(instr
)));
605 validate_assert(state
, nir_intrinsic_align_offset(instr
) <
606 nir_intrinsic_align_mul(instr
));
609 case nir_intrinsic_store_output
:
610 case nir_intrinsic_store_per_vertex_output
:
611 /* All memory store operations must store at least a byte */
612 validate_assert(state
, nir_src_bit_size(instr
->src
[0]) >= 8);
619 if (instr
->num_components
> 0)
620 validate_num_components(state
, instr
->num_components
);
622 const nir_intrinsic_info
*info
= &nir_intrinsic_infos
[instr
->intrinsic
];
623 unsigned num_srcs
= info
->num_srcs
;
624 for (unsigned i
= 0; i
< num_srcs
; i
++) {
625 unsigned components_read
= nir_intrinsic_src_components(instr
, i
);
627 validate_num_components(state
, components_read
);
629 validate_src(&instr
->src
[i
], state
, src_bit_sizes
[i
], components_read
);
632 if (nir_intrinsic_infos
[instr
->intrinsic
].has_dest
) {
633 unsigned components_written
= nir_intrinsic_dest_components(instr
);
634 unsigned bit_sizes
= nir_intrinsic_infos
[instr
->intrinsic
].dest_bit_sizes
;
636 validate_num_components(state
, components_written
);
637 if (dest_bit_size
&& bit_sizes
)
638 validate_assert(state
, dest_bit_size
& bit_sizes
);
640 dest_bit_size
= dest_bit_size
? dest_bit_size
: bit_sizes
;
642 validate_dest(&instr
->dest
, state
, dest_bit_size
, components_written
);
647 validate_tex_instr(nir_tex_instr
*instr
, validate_state
*state
)
649 bool src_type_seen
[nir_num_tex_src_types
];
650 for (unsigned i
= 0; i
< nir_num_tex_src_types
; i
++)
651 src_type_seen
[i
] = false;
653 for (unsigned i
= 0; i
< instr
->num_srcs
; i
++) {
654 validate_assert(state
, !src_type_seen
[instr
->src
[i
].src_type
]);
655 src_type_seen
[instr
->src
[i
].src_type
] = true;
656 validate_src(&instr
->src
[i
].src
, state
,
657 0, nir_tex_instr_src_size(instr
, i
));
659 switch (instr
->src
[i
].src_type
) {
660 case nir_tex_src_texture_deref
:
661 case nir_tex_src_sampler_deref
:
662 validate_assert(state
, instr
->src
[i
].src
.is_ssa
);
663 validate_assert(state
,
664 instr
->src
[i
].src
.ssa
->parent_instr
->type
== nir_instr_type_deref
);
671 if (nir_tex_instr_has_explicit_tg4_offsets(instr
)) {
672 validate_assert(state
, instr
->op
== nir_texop_tg4
);
673 validate_assert(state
, !src_type_seen
[nir_tex_src_offset
]);
676 validate_dest(&instr
->dest
, state
, 0, nir_tex_instr_dest_size(instr
));
680 validate_call_instr(nir_call_instr
*instr
, validate_state
*state
)
682 validate_assert(state
, instr
->num_params
== instr
->callee
->num_params
);
684 for (unsigned i
= 0; i
< instr
->num_params
; i
++) {
685 validate_src(&instr
->params
[i
], state
,
686 instr
->callee
->params
[i
].bit_size
,
687 instr
->callee
->params
[i
].num_components
);
692 validate_const_value(nir_const_value
*val
, unsigned bit_size
,
693 validate_state
*state
)
695 /* In order for block copies to work properly for things like instruction
696 * comparisons and [de]serialization, we require the unused bits of the
697 * nir_const_value to be zero.
699 nir_const_value cmp_val
;
700 memset(&cmp_val
, 0, sizeof(cmp_val
));
706 cmp_val
.u8
= val
->u8
;
709 cmp_val
.u16
= val
->u16
;
712 cmp_val
.u32
= val
->u32
;
715 cmp_val
.u64
= val
->u64
;
718 validate_assert(state
, !"Invalid load_const bit size");
720 validate_assert(state
, memcmp(val
, &cmp_val
, sizeof(cmp_val
)) == 0);
724 validate_load_const_instr(nir_load_const_instr
*instr
, validate_state
*state
)
726 validate_ssa_def(&instr
->def
, state
);
728 for (unsigned i
= 0; i
< instr
->def
.num_components
; i
++)
729 validate_const_value(&instr
->value
[i
], instr
->def
.bit_size
, state
);
733 validate_ssa_undef_instr(nir_ssa_undef_instr
*instr
, validate_state
*state
)
735 validate_ssa_def(&instr
->def
, state
);
739 validate_phi_instr(nir_phi_instr
*instr
, validate_state
*state
)
742 * don't validate the sources until we get to them from their predecessor
743 * basic blocks, to avoid validating an SSA use before its definition.
746 validate_dest(&instr
->dest
, state
, 0, 0);
748 exec_list_validate(&instr
->srcs
);
749 validate_assert(state
, exec_list_length(&instr
->srcs
) ==
750 state
->block
->predecessors
->entries
);
754 validate_instr(nir_instr
*instr
, validate_state
*state
)
756 validate_assert(state
, instr
->block
== state
->block
);
758 state
->instr
= instr
;
760 switch (instr
->type
) {
761 case nir_instr_type_alu
:
762 validate_alu_instr(nir_instr_as_alu(instr
), state
);
765 case nir_instr_type_deref
:
766 validate_deref_instr(nir_instr_as_deref(instr
), state
);
769 case nir_instr_type_call
:
770 validate_call_instr(nir_instr_as_call(instr
), state
);
773 case nir_instr_type_intrinsic
:
774 validate_intrinsic_instr(nir_instr_as_intrinsic(instr
), state
);
777 case nir_instr_type_tex
:
778 validate_tex_instr(nir_instr_as_tex(instr
), state
);
781 case nir_instr_type_load_const
:
782 validate_load_const_instr(nir_instr_as_load_const(instr
), state
);
785 case nir_instr_type_phi
:
786 validate_phi_instr(nir_instr_as_phi(instr
), state
);
789 case nir_instr_type_ssa_undef
:
790 validate_ssa_undef_instr(nir_instr_as_ssa_undef(instr
), state
);
793 case nir_instr_type_jump
:
797 validate_assert(state
, !"Invalid ALU instruction type");
805 validate_phi_src(nir_phi_instr
*instr
, nir_block
*pred
, validate_state
*state
)
807 state
->instr
= &instr
->instr
;
809 validate_assert(state
, instr
->dest
.is_ssa
);
811 exec_list_validate(&instr
->srcs
);
812 nir_foreach_phi_src(src
, instr
) {
813 if (src
->pred
== pred
) {
814 validate_assert(state
, src
->src
.is_ssa
);
815 validate_src(&src
->src
, state
, instr
->dest
.ssa
.bit_size
,
816 instr
->dest
.ssa
.num_components
);
826 validate_phi_srcs(nir_block
*block
, nir_block
*succ
, validate_state
*state
)
828 nir_foreach_instr(instr
, succ
) {
829 if (instr
->type
!= nir_instr_type_phi
)
832 validate_phi_src(nir_instr_as_phi(instr
), block
, state
);
836 static void validate_cf_node(nir_cf_node
*node
, validate_state
*state
);
839 validate_block(nir_block
*block
, validate_state
*state
)
841 validate_assert(state
, block
->cf_node
.parent
== state
->parent_node
);
843 state
->block
= block
;
845 exec_list_validate(&block
->instr_list
);
846 nir_foreach_instr(instr
, block
) {
847 if (instr
->type
== nir_instr_type_phi
) {
848 validate_assert(state
, instr
== nir_block_first_instr(block
) ||
849 nir_instr_prev(instr
)->type
== nir_instr_type_phi
);
852 if (instr
->type
== nir_instr_type_jump
) {
853 validate_assert(state
, instr
== nir_block_last_instr(block
));
856 validate_instr(instr
, state
);
859 validate_assert(state
, block
->successors
[0] != NULL
);
860 validate_assert(state
, block
->successors
[0] != block
->successors
[1]);
862 for (unsigned i
= 0; i
< 2; i
++) {
863 if (block
->successors
[i
] != NULL
) {
864 struct set_entry
*entry
=
865 _mesa_set_search(block
->successors
[i
]->predecessors
, block
);
866 validate_assert(state
, entry
);
868 validate_phi_srcs(block
, block
->successors
[i
], state
);
872 set_foreach(block
->predecessors
, entry
) {
873 const nir_block
*pred
= entry
->key
;
874 validate_assert(state
, pred
->successors
[0] == block
||
875 pred
->successors
[1] == block
);
878 if (!exec_list_is_empty(&block
->instr_list
) &&
879 nir_block_last_instr(block
)->type
== nir_instr_type_jump
) {
880 validate_assert(state
, block
->successors
[1] == NULL
);
881 nir_jump_instr
*jump
= nir_instr_as_jump(nir_block_last_instr(block
));
882 switch (jump
->type
) {
883 case nir_jump_break
: {
885 nir_cf_node_as_block(nir_cf_node_next(&state
->loop
->cf_node
));
886 validate_assert(state
, block
->successors
[0] == after
);
890 case nir_jump_continue
: {
891 nir_block
*first
= nir_loop_first_block(state
->loop
);
892 validate_assert(state
, block
->successors
[0] == first
);
896 case nir_jump_return
:
897 validate_assert(state
, block
->successors
[0] == state
->impl
->end_block
);
901 unreachable("bad jump type");
904 nir_cf_node
*next
= nir_cf_node_next(&block
->cf_node
);
906 switch (state
->parent_node
->type
) {
907 case nir_cf_node_loop
: {
908 nir_block
*first
= nir_loop_first_block(state
->loop
);
909 validate_assert(state
, block
->successors
[0] == first
);
910 /* due to the hack for infinite loops, block->successors[1] may
911 * point to the block after the loop.
916 case nir_cf_node_if
: {
918 nir_cf_node_as_block(nir_cf_node_next(state
->parent_node
));
919 validate_assert(state
, block
->successors
[0] == after
);
920 validate_assert(state
, block
->successors
[1] == NULL
);
924 case nir_cf_node_function
:
925 validate_assert(state
, block
->successors
[0] == state
->impl
->end_block
);
926 validate_assert(state
, block
->successors
[1] == NULL
);
930 unreachable("unknown control flow node type");
933 if (next
->type
== nir_cf_node_if
) {
934 nir_if
*if_stmt
= nir_cf_node_as_if(next
);
935 validate_assert(state
, block
->successors
[0] ==
936 nir_if_first_then_block(if_stmt
));
937 validate_assert(state
, block
->successors
[1] ==
938 nir_if_first_else_block(if_stmt
));
940 validate_assert(state
, next
->type
== nir_cf_node_loop
);
941 nir_loop
*loop
= nir_cf_node_as_loop(next
);
942 validate_assert(state
, block
->successors
[0] ==
943 nir_loop_first_block(loop
));
944 validate_assert(state
, block
->successors
[1] == NULL
);
951 validate_if(nir_if
*if_stmt
, validate_state
*state
)
953 state
->if_stmt
= if_stmt
;
955 validate_assert(state
, !exec_node_is_head_sentinel(if_stmt
->cf_node
.node
.prev
));
956 nir_cf_node
*prev_node
= nir_cf_node_prev(&if_stmt
->cf_node
);
957 validate_assert(state
, prev_node
->type
== nir_cf_node_block
);
959 validate_assert(state
, !exec_node_is_tail_sentinel(if_stmt
->cf_node
.node
.next
));
960 nir_cf_node
*next_node
= nir_cf_node_next(&if_stmt
->cf_node
);
961 validate_assert(state
, next_node
->type
== nir_cf_node_block
);
963 validate_src(&if_stmt
->condition
, state
, 0, 1);
965 validate_assert(state
, !exec_list_is_empty(&if_stmt
->then_list
));
966 validate_assert(state
, !exec_list_is_empty(&if_stmt
->else_list
));
968 nir_cf_node
*old_parent
= state
->parent_node
;
969 state
->parent_node
= &if_stmt
->cf_node
;
971 exec_list_validate(&if_stmt
->then_list
);
972 foreach_list_typed(nir_cf_node
, cf_node
, node
, &if_stmt
->then_list
) {
973 validate_cf_node(cf_node
, state
);
976 exec_list_validate(&if_stmt
->else_list
);
977 foreach_list_typed(nir_cf_node
, cf_node
, node
, &if_stmt
->else_list
) {
978 validate_cf_node(cf_node
, state
);
981 state
->parent_node
= old_parent
;
982 state
->if_stmt
= NULL
;
986 validate_loop(nir_loop
*loop
, validate_state
*state
)
988 validate_assert(state
, !exec_node_is_head_sentinel(loop
->cf_node
.node
.prev
));
989 nir_cf_node
*prev_node
= nir_cf_node_prev(&loop
->cf_node
);
990 validate_assert(state
, prev_node
->type
== nir_cf_node_block
);
992 validate_assert(state
, !exec_node_is_tail_sentinel(loop
->cf_node
.node
.next
));
993 nir_cf_node
*next_node
= nir_cf_node_next(&loop
->cf_node
);
994 validate_assert(state
, next_node
->type
== nir_cf_node_block
);
996 validate_assert(state
, !exec_list_is_empty(&loop
->body
));
998 nir_cf_node
*old_parent
= state
->parent_node
;
999 state
->parent_node
= &loop
->cf_node
;
1000 nir_loop
*old_loop
= state
->loop
;
1003 exec_list_validate(&loop
->body
);
1004 foreach_list_typed(nir_cf_node
, cf_node
, node
, &loop
->body
) {
1005 validate_cf_node(cf_node
, state
);
1008 state
->parent_node
= old_parent
;
1009 state
->loop
= old_loop
;
1013 validate_cf_node(nir_cf_node
*node
, validate_state
*state
)
1015 validate_assert(state
, node
->parent
== state
->parent_node
);
1017 switch (node
->type
) {
1018 case nir_cf_node_block
:
1019 validate_block(nir_cf_node_as_block(node
), state
);
1022 case nir_cf_node_if
:
1023 validate_if(nir_cf_node_as_if(node
), state
);
1026 case nir_cf_node_loop
:
1027 validate_loop(nir_cf_node_as_loop(node
), state
);
1031 unreachable("Invalid CF node type");
1036 prevalidate_reg_decl(nir_register
*reg
, validate_state
*state
)
1038 validate_assert(state
, reg
->index
< state
->impl
->reg_alloc
);
1039 validate_assert(state
, !BITSET_TEST(state
->regs_found
, reg
->index
));
1040 validate_num_components(state
, reg
->num_components
);
1041 BITSET_SET(state
->regs_found
, reg
->index
);
1043 list_validate(®
->uses
);
1044 list_validate(®
->defs
);
1045 list_validate(®
->if_uses
);
1047 reg_validate_state
*reg_state
= ralloc(state
->regs
, reg_validate_state
);
1048 reg_state
->uses
= _mesa_pointer_set_create(reg_state
);
1049 reg_state
->if_uses
= _mesa_pointer_set_create(reg_state
);
1050 reg_state
->defs
= _mesa_pointer_set_create(reg_state
);
1052 reg_state
->where_defined
= state
->impl
;
1054 _mesa_hash_table_insert(state
->regs
, reg
, reg_state
);
1058 postvalidate_reg_decl(nir_register
*reg
, validate_state
*state
)
1060 struct hash_entry
*entry
= _mesa_hash_table_search(state
->regs
, reg
);
1063 reg_validate_state
*reg_state
= (reg_validate_state
*) entry
->data
;
1065 nir_foreach_use(src
, reg
) {
1066 struct set_entry
*entry
= _mesa_set_search(reg_state
->uses
, src
);
1067 validate_assert(state
, entry
);
1068 _mesa_set_remove(reg_state
->uses
, entry
);
1071 if (reg_state
->uses
->entries
!= 0) {
1072 printf("extra entries in register uses:\n");
1073 set_foreach(reg_state
->uses
, entry
)
1074 printf("%p\n", entry
->key
);
1079 nir_foreach_if_use(src
, reg
) {
1080 struct set_entry
*entry
= _mesa_set_search(reg_state
->if_uses
, src
);
1081 validate_assert(state
, entry
);
1082 _mesa_set_remove(reg_state
->if_uses
, entry
);
1085 if (reg_state
->if_uses
->entries
!= 0) {
1086 printf("extra entries in register if_uses:\n");
1087 set_foreach(reg_state
->if_uses
, entry
)
1088 printf("%p\n", entry
->key
);
1093 nir_foreach_def(src
, reg
) {
1094 struct set_entry
*entry
= _mesa_set_search(reg_state
->defs
, src
);
1095 validate_assert(state
, entry
);
1096 _mesa_set_remove(reg_state
->defs
, entry
);
1099 if (reg_state
->defs
->entries
!= 0) {
1100 printf("extra entries in register defs:\n");
1101 set_foreach(reg_state
->defs
, entry
)
1102 printf("%p\n", entry
->key
);
1109 validate_var_decl(nir_variable
*var
, nir_variable_mode valid_modes
,
1110 validate_state
*state
)
1114 /* Must have exactly one mode set */
1115 validate_assert(state
, util_is_power_of_two_nonzero(var
->data
.mode
));
1116 validate_assert(state
, var
->data
.mode
& valid_modes
);
1118 if (var
->data
.compact
) {
1119 /* The "compact" flag is only valid on arrays of scalars. */
1120 assert(glsl_type_is_array(var
->type
));
1122 const struct glsl_type
*type
= glsl_get_array_element(var
->type
);
1123 if (nir_is_per_vertex_io(var
, state
->shader
->info
.stage
)) {
1124 assert(glsl_type_is_array(type
));
1125 assert(glsl_type_is_scalar(glsl_get_array_element(type
)));
1127 assert(glsl_type_is_scalar(type
));
1131 if (var
->num_members
> 0) {
1132 const struct glsl_type
*without_array
= glsl_without_array(var
->type
);
1133 validate_assert(state
, glsl_type_is_struct_or_ifc(without_array
));
1134 validate_assert(state
, var
->num_members
== glsl_get_length(without_array
));
1135 validate_assert(state
, var
->members
!= NULL
);
1138 if (var
->data
.per_view
)
1139 validate_assert(state
, glsl_type_is_array(var
->type
));
1142 * TODO validate some things ir_validate.cpp does (requires more GLSL type
1146 _mesa_hash_table_insert(state
->var_defs
, var
,
1147 valid_modes
== nir_var_function_temp
?
1148 state
->impl
: NULL
);
1154 validate_function_impl(nir_function_impl
*impl
, validate_state
*state
)
1156 /* Resize the ssa_srcs set. It's likely that the size of this set will
1157 * never actually hit the number of SSA defs because we remove sources from
1158 * the set as we visit them. (It could actually be much larger because
1159 * each SSA def can be used more than once.) However, growing it now costs
1160 * us very little (the extra memory is already dwarfed by the SSA defs
1161 * themselves) and makes collisions much less likely.
1163 _mesa_set_resize(state
->ssa_srcs
, impl
->ssa_alloc
);
1165 validate_assert(state
, impl
->function
->impl
== impl
);
1166 validate_assert(state
, impl
->cf_node
.parent
== NULL
);
1168 validate_assert(state
, exec_list_is_empty(&impl
->end_block
->instr_list
));
1169 validate_assert(state
, impl
->end_block
->successors
[0] == NULL
);
1170 validate_assert(state
, impl
->end_block
->successors
[1] == NULL
);
1173 state
->parent_node
= &impl
->cf_node
;
1175 exec_list_validate(&impl
->locals
);
1176 nir_foreach_variable(var
, &impl
->locals
) {
1177 validate_var_decl(var
, nir_var_function_temp
, state
);
1180 state
->regs_found
= reralloc(state
->mem_ctx
, state
->regs_found
,
1181 BITSET_WORD
, BITSET_WORDS(impl
->reg_alloc
));
1182 memset(state
->regs_found
, 0, BITSET_WORDS(impl
->reg_alloc
) *
1183 sizeof(BITSET_WORD
));
1184 exec_list_validate(&impl
->registers
);
1185 foreach_list_typed(nir_register
, reg
, node
, &impl
->registers
) {
1186 prevalidate_reg_decl(reg
, state
);
1189 state
->ssa_defs_found
= reralloc(state
->mem_ctx
, state
->ssa_defs_found
,
1190 BITSET_WORD
, BITSET_WORDS(impl
->ssa_alloc
));
1191 memset(state
->ssa_defs_found
, 0, BITSET_WORDS(impl
->ssa_alloc
) *
1192 sizeof(BITSET_WORD
));
1193 exec_list_validate(&impl
->body
);
1194 foreach_list_typed(nir_cf_node
, node
, node
, &impl
->body
) {
1195 validate_cf_node(node
, state
);
1198 foreach_list_typed(nir_register
, reg
, node
, &impl
->registers
) {
1199 postvalidate_reg_decl(reg
, state
);
1202 if (state
->ssa_srcs
->entries
!= 0) {
1203 printf("extra dangling SSA sources:\n");
1204 set_foreach(state
->ssa_srcs
, entry
)
1205 printf("%p\n", entry
->key
);
1212 validate_function(nir_function
*func
, validate_state
*state
)
1214 if (func
->impl
!= NULL
) {
1215 validate_assert(state
, func
->impl
->function
== func
);
1216 validate_function_impl(func
->impl
, state
);
1221 init_validate_state(validate_state
*state
)
1223 state
->mem_ctx
= ralloc_context(NULL
);
1224 state
->regs
= _mesa_pointer_hash_table_create(state
->mem_ctx
);
1225 state
->ssa_srcs
= _mesa_pointer_set_create(state
->mem_ctx
);
1226 state
->ssa_defs_found
= NULL
;
1227 state
->regs_found
= NULL
;
1228 state
->var_defs
= _mesa_pointer_hash_table_create(state
->mem_ctx
);
1229 state
->errors
= _mesa_pointer_hash_table_create(state
->mem_ctx
);
1232 state
->instr
= NULL
;
1237 destroy_validate_state(validate_state
*state
)
1239 ralloc_free(state
->mem_ctx
);
1242 mtx_t fail_dump_mutex
= _MTX_INITIALIZER_NP
;
1245 dump_errors(validate_state
*state
, const char *when
)
1247 struct hash_table
*errors
= state
->errors
;
1249 /* Lock around dumping so that we get clean dumps in a multi-threaded
1252 mtx_lock(&fail_dump_mutex
);
1255 fprintf(stderr
, "NIR validation failed %s\n", when
);
1256 fprintf(stderr
, "%d errors:\n", _mesa_hash_table_num_entries(errors
));
1258 fprintf(stderr
, "NIR validation failed with %d errors:\n",
1259 _mesa_hash_table_num_entries(errors
));
1262 nir_print_shader_annotated(state
->shader
, stderr
, errors
);
1264 if (_mesa_hash_table_num_entries(errors
) > 0) {
1265 fprintf(stderr
, "%d additional errors:\n",
1266 _mesa_hash_table_num_entries(errors
));
1267 hash_table_foreach(errors
, entry
) {
1268 fprintf(stderr
, "%s\n", (char *)entry
->data
);
1272 mtx_unlock(&fail_dump_mutex
);
1278 nir_validate_shader(nir_shader
*shader
, const char *when
)
1280 static int should_validate
= -1;
1281 if (should_validate
< 0)
1282 should_validate
= env_var_as_boolean("NIR_VALIDATE", true);
1283 if (!should_validate
)
1286 validate_state state
;
1287 init_validate_state(&state
);
1289 state
.shader
= shader
;
1291 exec_list_validate(&shader
->uniforms
);
1292 nir_foreach_variable(var
, &shader
->uniforms
) {
1293 validate_var_decl(var
, nir_var_uniform
|
1299 exec_list_validate(&shader
->inputs
);
1300 nir_foreach_variable(var
, &shader
->inputs
) {
1301 validate_var_decl(var
, nir_var_shader_in
, &state
);
1304 exec_list_validate(&shader
->outputs
);
1305 nir_foreach_variable(var
, &shader
->outputs
) {
1306 validate_var_decl(var
, nir_var_shader_out
, &state
);
1309 exec_list_validate(&shader
->shared
);
1310 nir_foreach_variable(var
, &shader
->shared
) {
1311 validate_var_decl(var
, nir_var_mem_shared
, &state
);
1314 exec_list_validate(&shader
->globals
);
1315 nir_foreach_variable(var
, &shader
->globals
) {
1316 validate_var_decl(var
, nir_var_shader_temp
, &state
);
1319 exec_list_validate(&shader
->system_values
);
1320 nir_foreach_variable(var
, &shader
->system_values
) {
1321 validate_var_decl(var
, nir_var_system_value
, &state
);
1324 exec_list_validate(&shader
->functions
);
1325 foreach_list_typed(nir_function
, func
, node
, &shader
->functions
) {
1326 validate_function(func
, &state
);
1329 if (_mesa_hash_table_num_entries(state
.errors
) > 0)
1330 dump_errors(&state
, when
);
1332 destroy_validate_state(&state
);