src/freedreno/vulkan/tu_image.c

   1 /*
   2  * Copyright © 2016 Red Hat.
   3  * Copyright © 2016 Bas Nieuwenhuizen
   4  *
   5  * based in part on anv driver which is:
   6  * Copyright © 2015 Intel Corporation
   7  *
   8  * Permission is hereby granted, free of charge, to any person obtaining a
   9  * copy of this software and associated documentation files (the "Software"),
  10  * to deal in the Software without restriction, including without limitation
  11  * the rights to use, copy, modify, merge, publish, distribute, sublicense,
  12  * and/or sell copies of the Software, and to permit persons to whom the
  13  * Software is furnished to do so, subject to the following conditions:
  14  *
  15  * The above copyright notice and this permission notice (including the next
  16  * paragraph) shall be included in all copies or substantial portions of the
  17  * Software.
  18  *
  19  * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
  20  * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
  21  * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
  22  * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
  23  * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
  24  * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER
  25  * DEALINGS IN THE SOFTWARE.
  26  */
  27
  28 #include "tu_private.h"
  29
  30 #include "util/debug.h"
  31 #include "util/u_atomic.h"
  32 #include "util/format/u_format.h"
  33 #include "vk_format.h"
  34 #include "vk_util.h"
  35 #include "drm-uapi/drm_fourcc.h"
  36
  37 static inline bool
  38 image_level_linear(struct tu_image *image, int level, bool ubwc)
  39 {
  40    unsigned w = u_minify(image->extent.width, level);
  41    /* all levels are tiled/compressed with UBWC */
  42    return ubwc ? false : (w < 16);
  43 }
  44
  45 enum a6xx_tile_mode
  46 tu6_get_image_tile_mode(struct tu_image *image, int level)
  47 {
  48    if (image_level_linear(image, level, !!image->layout.ubwc_layer_size))
  49       return TILE6_LINEAR;
  50    else
  51       return image->layout.tile_mode;
  52 }
  53
  54 VkResult
  55 tu_image_create(VkDevice _device,
  56                 const VkImageCreateInfo *pCreateInfo,
  57                 const VkAllocationCallbacks *alloc,
  58                 VkImage *pImage,
  59                 uint64_t modifier)
  60 {
  61    TU_FROM_HANDLE(tu_device, device, _device);
  62    struct tu_image *image = NULL;
  63    assert(pCreateInfo->sType == VK_STRUCTURE_TYPE_IMAGE_CREATE_INFO);
  64
  65    tu_assert(pCreateInfo->mipLevels > 0);
  66    tu_assert(pCreateInfo->arrayLayers > 0);
  67    tu_assert(pCreateInfo->samples > 0);
  68    tu_assert(pCreateInfo->extent.width > 0);
  69    tu_assert(pCreateInfo->extent.height > 0);
  70    tu_assert(pCreateInfo->extent.depth > 0);
  71
  72    image = vk_zalloc2(&device->alloc, alloc, sizeof(*image), 8,
  73                       VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
  74    if (!image)
  75       return vk_error(device->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
  76
  77    image->type = pCreateInfo->imageType;
  78
  79    image->vk_format = pCreateInfo->format;
  80    image->tiling = pCreateInfo->tiling;
  81    image->usage = pCreateInfo->usage;
  82    image->flags = pCreateInfo->flags;
  83    image->extent = pCreateInfo->extent;
  84    image->level_count = pCreateInfo->mipLevels;
  85    image->layer_count = pCreateInfo->arrayLayers;
  86    image->samples = pCreateInfo->samples;
  87
  88    image->exclusive = pCreateInfo->sharingMode == VK_SHARING_MODE_EXCLUSIVE;
  89    if (pCreateInfo->sharingMode == VK_SHARING_MODE_CONCURRENT) {
  90       for (uint32_t i = 0; i < pCreateInfo->queueFamilyIndexCount; ++i)
  91          if (pCreateInfo->pQueueFamilyIndices[i] ==
  92              VK_QUEUE_FAMILY_EXTERNAL)
  93             image->queue_family_mask |= (1u << TU_MAX_QUEUE_FAMILIES) - 1u;
  94          else
  95             image->queue_family_mask |=
  96                1u << pCreateInfo->pQueueFamilyIndices[i];
  97    }
  98
  99    image->shareable =
 100       vk_find_struct_const(pCreateInfo->pNext,
 101                            EXTERNAL_MEMORY_IMAGE_CREATE_INFO) != NULL;
 102
 103    image->layout.tile_mode = TILE6_3;
 104    bool ubwc_enabled = true;
 105
 106    /* disable tiling when linear is requested and for compressed formats */
 107    if (pCreateInfo->tiling == VK_IMAGE_TILING_LINEAR ||
 108        modifier == DRM_FORMAT_MOD_LINEAR ||
 109        vk_format_is_compressed(image->vk_format)) {
 110       image->layout.tile_mode = TILE6_LINEAR;
 111       ubwc_enabled = false;
 112    }
 113
 114    /* using UBWC with D24S8 breaks the "stencil read" copy path (why?)
 115     * (causes any deqp tests that need to check stencil to fail)
 116     * disable UBWC for this format until we properly support copy aspect masks
 117     */
 118    if (image->vk_format == VK_FORMAT_D24_UNORM_S8_UINT)
 119       ubwc_enabled = false;
 120
 121    /* UBWC can't be used with E5B9G9R9 */
 122    if (image->vk_format == VK_FORMAT_E5B9G9R9_UFLOAT_PACK32)
 123       ubwc_enabled = false;
 124
 125    if (image->extent.depth > 1) {
 126       tu_finishme("UBWC with 3D textures");
 127       ubwc_enabled = false;
 128    }
 129
 130    /* Disable UBWC for storage images.
 131     *
 132     * The closed GL driver skips UBWC for storage images (and additionally
 133     * uses linear for writeonly images).  We seem to have image tiling working
 134     * in freedreno in general, so turnip matches that.  freedreno also enables
 135     * UBWC on images, but it's not really tested due to the lack of
 136     * UBWC-enabled mipmaps in freedreno currently.  Just match the closed GL
 137     * behavior of no UBWC.
 138    */
 139    if (image->usage & VK_IMAGE_USAGE_STORAGE_BIT)
 140       ubwc_enabled = false;
 141
 142    uint32_t ubwc_blockwidth, ubwc_blockheight;
 143    fdl6_get_ubwc_blockwidth(&image->layout,
 144                             &ubwc_blockwidth, &ubwc_blockheight);
 145    if (!ubwc_blockwidth) {
 146       tu_finishme("UBWC for cpp=%d", image->layout.cpp);
 147       ubwc_enabled = false;
 148    }
 149
 150    /* expect UBWC enabled if we asked for it */
 151    assert(modifier != DRM_FORMAT_MOD_QCOM_COMPRESSED || ubwc_enabled);
 152
 153    fdl6_layout(&image->layout, vk_format_to_pipe_format(image->vk_format),
 154                image->samples,
 155                pCreateInfo->extent.width,
 156                pCreateInfo->extent.height,
 157                pCreateInfo->extent.depth,
 158                pCreateInfo->mipLevels,
 159                pCreateInfo->arrayLayers,
 160                pCreateInfo->imageType == VK_IMAGE_TYPE_3D,
 161                ubwc_enabled);
 162
 163    *pImage = tu_image_to_handle(image);
 164
 165    return VK_SUCCESS;
 166 }
 167
 168 static enum a6xx_tex_fetchsize
 169 tu6_fetchsize(VkFormat format)
 170 {
 171    if (vk_format_description(format)->layout == UTIL_FORMAT_LAYOUT_ASTC)
 172       return TFETCH6_16_BYTE;
 173
 174    switch (vk_format_get_blocksize(format) / vk_format_get_blockwidth(format)) {
 175    case 1: return TFETCH6_1_BYTE;
 176    case 2: return TFETCH6_2_BYTE;
 177    case 4: return TFETCH6_4_BYTE;
 178    case 8: return TFETCH6_8_BYTE;
 179    case 16: return TFETCH6_16_BYTE;
 180    default:
 181       unreachable("bad block size");
 182    }
 183 }
 184
 185 static uint32_t
 186 tu6_texswiz(const VkComponentMapping *comps,
 187             VkFormat format,
 188             VkImageAspectFlagBits aspect_mask)
 189 {
 190    unsigned char swiz[4] = {comps->r, comps->g, comps->b, comps->a};
 191    unsigned char vk_swizzle[] = {
 192       [VK_COMPONENT_SWIZZLE_ZERO] = A6XX_TEX_ZERO,
 193       [VK_COMPONENT_SWIZZLE_ONE]  = A6XX_TEX_ONE,
 194       [VK_COMPONENT_SWIZZLE_R] = A6XX_TEX_X,
 195       [VK_COMPONENT_SWIZZLE_G] = A6XX_TEX_Y,
 196       [VK_COMPONENT_SWIZZLE_B] = A6XX_TEX_Z,
 197       [VK_COMPONENT_SWIZZLE_A] = A6XX_TEX_W,
 198    };
 199    const unsigned char *fmt_swiz = vk_format_description(format)->swizzle;
 200
 201    for (unsigned i = 0; i < 4; i++) {
 202       swiz[i] = (swiz[i] == VK_COMPONENT_SWIZZLE_IDENTITY) ? i : vk_swizzle[swiz[i]];
 203       /* if format has 0/1 in channel, use that (needed for bc1_rgb) */
 204       if (swiz[i] < 4) {
 205          if (aspect_mask == VK_IMAGE_ASPECT_STENCIL_BIT &&
 206              format == VK_FORMAT_D24_UNORM_S8_UINT)
 207             swiz[i] = A6XX_TEX_Y;
 208          switch (fmt_swiz[swiz[i]]) {
 209          case PIPE_SWIZZLE_0: swiz[i] = A6XX_TEX_ZERO; break;
 210          case PIPE_SWIZZLE_1: swiz[i] = A6XX_TEX_ONE;  break;
 211          }
 212       }
 213    }
 214
 215    return A6XX_TEX_CONST_0_SWIZ_X(swiz[0]) |
 216           A6XX_TEX_CONST_0_SWIZ_Y(swiz[1]) |
 217           A6XX_TEX_CONST_0_SWIZ_Z(swiz[2]) |
 218           A6XX_TEX_CONST_0_SWIZ_W(swiz[3]);
 219 }
 220
 221 static enum a6xx_tex_type
 222 tu6_tex_type(VkImageViewType type)
 223 {
 224    switch (type) {
 225    default:
 226    case VK_IMAGE_VIEW_TYPE_1D:
 227    case VK_IMAGE_VIEW_TYPE_1D_ARRAY:
 228       return A6XX_TEX_1D;
 229    case VK_IMAGE_VIEW_TYPE_2D:
 230    case VK_IMAGE_VIEW_TYPE_2D_ARRAY:
 231       return A6XX_TEX_2D;
 232    case VK_IMAGE_VIEW_TYPE_3D:
 233       return A6XX_TEX_3D;
 234    case VK_IMAGE_VIEW_TYPE_CUBE:
 235    case VK_IMAGE_VIEW_TYPE_CUBE_ARRAY:
 236       return A6XX_TEX_CUBE;
 237    }
 238 }
 239
 240 void
 241 tu_image_view_init(struct tu_image_view *iview,
 242                    struct tu_device *device,
 243                    const VkImageViewCreateInfo *pCreateInfo)
 244 {
 245    TU_FROM_HANDLE(tu_image, image, pCreateInfo->image);
 246    const VkImageSubresourceRange *range = &pCreateInfo->subresourceRange;
 247
 248    switch (image->type) {
 249    case VK_IMAGE_TYPE_1D:
 250    case VK_IMAGE_TYPE_2D:
 251       assert(range->baseArrayLayer + tu_get_layerCount(image, range) <=
 252              image->layer_count);
 253       break;
 254    case VK_IMAGE_TYPE_3D:
 255       assert(range->baseArrayLayer + tu_get_layerCount(image, range) <=
 256              tu_minify(image->extent.depth, range->baseMipLevel));
 257       break;
 258    default:
 259       unreachable("bad VkImageType");
 260    }
 261
 262    iview->image = image;
 263    iview->type = pCreateInfo->viewType;
 264    iview->vk_format = pCreateInfo->format;
 265    iview->aspect_mask = pCreateInfo->subresourceRange.aspectMask;
 266
 267    // should we minify?
 268    iview->extent = image->extent;
 269
 270    iview->base_layer = range->baseArrayLayer;
 271    iview->layer_count = tu_get_layerCount(image, range);
 272    iview->base_mip = range->baseMipLevel;
 273    iview->level_count = tu_get_levelCount(image, range);
 274
 275    memset(iview->descriptor, 0, sizeof(iview->descriptor));
 276
 277    const struct tu_native_format *fmt = tu6_get_native_format(iview->vk_format);
 278    uint64_t base_addr = tu_image_base(image, iview->base_mip, iview->base_layer);
 279    uint64_t ubwc_addr = tu_image_ubwc_base(image, iview->base_mip, iview->base_layer);
 280
 281    uint32_t pitch = tu_image_stride(image, iview->base_mip) / vk_format_get_blockwidth(iview->vk_format);
 282    enum a6xx_tile_mode tile_mode = tu6_get_image_tile_mode(image, iview->base_mip);
 283    uint32_t width = u_minify(image->extent.width, iview->base_mip);
 284    uint32_t height = u_minify(image->extent.height, iview->base_mip);
 285    uint32_t depth = pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_3D ?
 286       u_minify(image->extent.depth, iview->base_mip) : iview->layer_count;
 287
 288    unsigned fmt_tex = fmt->tex;
 289    if (iview->aspect_mask == VK_IMAGE_ASPECT_STENCIL_BIT &&
 290        iview->vk_format == VK_FORMAT_D24_UNORM_S8_UINT)
 291       fmt_tex = TFMT6_S8Z24_UINT;
 292
 293    iview->descriptor[0] =
 294       A6XX_TEX_CONST_0_TILE_MODE(tile_mode) |
 295       COND(vk_format_is_srgb(iview->vk_format), A6XX_TEX_CONST_0_SRGB) |
 296       A6XX_TEX_CONST_0_FMT(fmt_tex) |
 297       A6XX_TEX_CONST_0_SAMPLES(tu_msaa_samples(image->samples)) |
 298       A6XX_TEX_CONST_0_SWAP(image->layout.tile_mode ? WZYX : fmt->swap) |
 299       tu6_texswiz(&pCreateInfo->components, iview->vk_format, iview->aspect_mask) |
 300       A6XX_TEX_CONST_0_MIPLVLS(iview->level_count - 1);
 301    iview->descriptor[1] = A6XX_TEX_CONST_1_WIDTH(width) | A6XX_TEX_CONST_1_HEIGHT(height);
 302    iview->descriptor[2] =
 303       A6XX_TEX_CONST_2_FETCHSIZE(tu6_fetchsize(iview->vk_format)) |
 304       A6XX_TEX_CONST_2_PITCH(pitch) |
 305       A6XX_TEX_CONST_2_TYPE(tu6_tex_type(pCreateInfo->viewType));
 306    iview->descriptor[3] = A6XX_TEX_CONST_3_ARRAY_PITCH(tu_layer_size(image, iview->base_mip));
 307    iview->descriptor[4] = base_addr;
 308    iview->descriptor[5] = (base_addr >> 32) | A6XX_TEX_CONST_5_DEPTH(depth);
 309
 310    if (image->layout.ubwc_layer_size) {
 311       uint32_t block_width, block_height;
 312       fdl6_get_ubwc_blockwidth(&image->layout,
 313                                &block_width, &block_height);
 314
 315       iview->descriptor[3] |= A6XX_TEX_CONST_3_FLAG | A6XX_TEX_CONST_3_TILE_ALL;
 316       iview->descriptor[7] = ubwc_addr;
 317       iview->descriptor[8] = ubwc_addr >> 32;
 318       iview->descriptor[9] |= A6XX_TEX_CONST_9_FLAG_BUFFER_ARRAY_PITCH(tu_image_ubwc_size(image, iview->base_mip) >> 2);
 319       iview->descriptor[10] |=
 320          A6XX_TEX_CONST_10_FLAG_BUFFER_PITCH(tu_image_ubwc_pitch(image, iview->base_mip)) |
 321          A6XX_TEX_CONST_10_FLAG_BUFFER_LOGW(util_logbase2_ceil(DIV_ROUND_UP(width, block_width))) |
 322          A6XX_TEX_CONST_10_FLAG_BUFFER_LOGH(util_logbase2_ceil(DIV_ROUND_UP(height, block_height)));
 323    }
 324
 325    if (pCreateInfo->viewType == VK_IMAGE_VIEW_TYPE_3D) {
 326       iview->descriptor[3] |=
 327          A6XX_TEX_CONST_3_MIN_LAYERSZ(image->layout.slices[image->level_count - 1].size0);
 328    }
 329
 330    if (image->usage & VK_IMAGE_USAGE_STORAGE_BIT) {
 331       memset(iview->storage_descriptor, 0, sizeof(iview->storage_descriptor));
 332
 333       iview->storage_descriptor[0] =
 334          A6XX_IBO_0_FMT(fmt->tex) |
 335          A6XX_IBO_0_TILE_MODE(tile_mode);
 336       iview->storage_descriptor[1] =
 337          A6XX_IBO_1_WIDTH(width) |
 338          A6XX_IBO_1_HEIGHT(height);
 339       iview->storage_descriptor[2] =
 340          A6XX_IBO_2_PITCH(pitch) |
 341          A6XX_IBO_2_TYPE(tu6_tex_type(pCreateInfo->viewType));
 342       iview->storage_descriptor[3] = A6XX_IBO_3_ARRAY_PITCH(tu_layer_size(image, iview->base_mip));
 343
 344       iview->storage_descriptor[4] = base_addr;
 345       iview->storage_descriptor[5] = (base_addr >> 32) | A6XX_IBO_5_DEPTH(depth);
 346
 347       if (image->layout.ubwc_layer_size) {
 348          iview->storage_descriptor[3] |= A6XX_IBO_3_FLAG | A6XX_IBO_3_UNK27;
 349          iview->storage_descriptor[7] |= ubwc_addr;
 350          iview->storage_descriptor[8] |= ubwc_addr >> 32;
 351          iview->storage_descriptor[9] = A6XX_IBO_9_FLAG_BUFFER_ARRAY_PITCH(tu_image_ubwc_size(image, iview->base_mip) >> 2);
 352          iview->storage_descriptor[10] =
 353             A6XX_IBO_10_FLAG_BUFFER_PITCH(tu_image_ubwc_pitch(image, iview->base_mip));
 354       }
 355    }
 356 }
 357
 358 unsigned
 359 tu_image_queue_family_mask(const struct tu_image *image,
 360                            uint32_t family,
 361                            uint32_t queue_family)
 362 {
 363    if (!image->exclusive)
 364       return image->queue_family_mask;
 365    if (family == VK_QUEUE_FAMILY_EXTERNAL)
 366       return (1u << TU_MAX_QUEUE_FAMILIES) - 1u;
 367    if (family == VK_QUEUE_FAMILY_IGNORED)
 368       return 1u << queue_family;
 369    return 1u << family;
 370 }
 371
 372 VkResult
 373 tu_CreateImage(VkDevice device,
 374                const VkImageCreateInfo *pCreateInfo,
 375                const VkAllocationCallbacks *pAllocator,
 376                VkImage *pImage)
 377 {
 378 #ifdef ANDROID
 379    const VkNativeBufferANDROID *gralloc_info =
 380       vk_find_struct_const(pCreateInfo->pNext, NATIVE_BUFFER_ANDROID);
 381
 382    if (gralloc_info)
 383       return tu_image_from_gralloc(device, pCreateInfo, gralloc_info,
 384                                    pAllocator, pImage);
 385 #endif
 386
 387    uint64_t modifier = DRM_FORMAT_MOD_INVALID;
 388    if (pCreateInfo->tiling == VK_IMAGE_TILING_DRM_FORMAT_MODIFIER_EXT) {
 389       const VkImageDrmFormatModifierListCreateInfoEXT *mod_info =
 390          vk_find_struct_const(pCreateInfo->pNext,
 391                               IMAGE_DRM_FORMAT_MODIFIER_LIST_CREATE_INFO_EXT);
 392
 393       modifier = DRM_FORMAT_MOD_LINEAR;
 394       for (unsigned i = 0; i < mod_info->drmFormatModifierCount; i++) {
 395          if (mod_info->pDrmFormatModifiers[i] == DRM_FORMAT_MOD_QCOM_COMPRESSED)
 396             modifier = DRM_FORMAT_MOD_QCOM_COMPRESSED;
 397       }
 398    } else {
 399       const struct wsi_image_create_info *wsi_info =
 400          vk_find_struct_const(pCreateInfo->pNext, WSI_IMAGE_CREATE_INFO_MESA);
 401       if (wsi_info && wsi_info->scanout)
 402          modifier = DRM_FORMAT_MOD_LINEAR;
 403    }
 404
 405    return tu_image_create(device, pCreateInfo, pAllocator, pImage, modifier);
 406 }
 407
 408 void
 409 tu_DestroyImage(VkDevice _device,
 410                 VkImage _image,
 411                 const VkAllocationCallbacks *pAllocator)
 412 {
 413    TU_FROM_HANDLE(tu_device, device, _device);
 414    TU_FROM_HANDLE(tu_image, image, _image);
 415
 416    if (!image)
 417       return;
 418
 419    if (image->owned_memory != VK_NULL_HANDLE)
 420       tu_FreeMemory(_device, image->owned_memory, pAllocator);
 421
 422    vk_free2(&device->alloc, pAllocator, image);
 423 }
 424
 425 void
 426 tu_GetImageSubresourceLayout(VkDevice _device,
 427                              VkImage _image,
 428                              const VkImageSubresource *pSubresource,
 429                              VkSubresourceLayout *pLayout)
 430 {
 431    TU_FROM_HANDLE(tu_image, image, _image);
 432
 433    const struct fdl_slice *slice = image->layout.slices + pSubresource->mipLevel;
 434
 435    pLayout->offset = fdl_surface_offset(&image->layout,
 436                                         pSubresource->mipLevel,
 437                                         pSubresource->arrayLayer);
 438    pLayout->size = slice->size0;
 439    pLayout->rowPitch =
 440       slice->pitch * vk_format_get_blocksize(image->vk_format);
 441    pLayout->arrayPitch = image->layout.layer_size;
 442    pLayout->depthPitch = slice->size0;
 443
 444    if (image->layout.ubwc_layer_size) {
 445       /* UBWC starts at offset 0 */
 446       pLayout->offset = 0;
 447       /* UBWC scanout won't match what the kernel wants if we have levels/layers */
 448       assert(image->level_count == 1 && image->layer_count == 1);
 449    }
 450 }
 451
 452 VkResult tu_GetImageDrmFormatModifierPropertiesEXT(
 453     VkDevice                                    device,
 454     VkImage                                     _image,
 455     VkImageDrmFormatModifierPropertiesEXT*      pProperties)
 456 {
 457    TU_FROM_HANDLE(tu_image, image, _image);
 458
 459    assert(pProperties->sType ==
 460           VK_STRUCTURE_TYPE_IMAGE_DRM_FORMAT_MODIFIER_PROPERTIES_EXT);
 461
 462    /* TODO invent a modifier for tiled but not UBWC buffers */
 463
 464    if (!image->layout.tile_mode)
 465       pProperties->drmFormatModifier = DRM_FORMAT_MOD_LINEAR;
 466    else if (image->layout.ubwc_layer_size)
 467       pProperties->drmFormatModifier = DRM_FORMAT_MOD_QCOM_COMPRESSED;
 468    else
 469       pProperties->drmFormatModifier = DRM_FORMAT_MOD_INVALID;
 470
 471    return VK_SUCCESS;
 472 }
 473
 474
 475 VkResult
 476 tu_CreateImageView(VkDevice _device,
 477                    const VkImageViewCreateInfo *pCreateInfo,
 478                    const VkAllocationCallbacks *pAllocator,
 479                    VkImageView *pView)
 480 {
 481    TU_FROM_HANDLE(tu_device, device, _device);
 482    struct tu_image_view *view;
 483
 484    view = vk_alloc2(&device->alloc, pAllocator, sizeof(*view), 8,
 485                     VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 486    if (view == NULL)
 487       return vk_error(device->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
 488
 489    tu_image_view_init(view, device, pCreateInfo);
 490
 491    *pView = tu_image_view_to_handle(view);
 492
 493    return VK_SUCCESS;
 494 }
 495
 496 void
 497 tu_DestroyImageView(VkDevice _device,
 498                     VkImageView _iview,
 499                     const VkAllocationCallbacks *pAllocator)
 500 {
 501    TU_FROM_HANDLE(tu_device, device, _device);
 502    TU_FROM_HANDLE(tu_image_view, iview, _iview);
 503
 504    if (!iview)
 505       return;
 506    vk_free2(&device->alloc, pAllocator, iview);
 507 }
 508
 509 void
 510 tu_buffer_view_init(struct tu_buffer_view *view,
 511                     struct tu_device *device,
 512                     const VkBufferViewCreateInfo *pCreateInfo)
 513 {
 514    TU_FROM_HANDLE(tu_buffer, buffer, pCreateInfo->buffer);
 515
 516    view->buffer = buffer;
 517
 518    enum VkFormat vfmt = pCreateInfo->format;
 519    enum pipe_format pfmt = vk_format_to_pipe_format(vfmt);
 520    const struct tu_native_format *fmt = tu6_get_native_format(vfmt);
 521
 522    uint32_t range;
 523    if (pCreateInfo->range == VK_WHOLE_SIZE)
 524       range = buffer->size - pCreateInfo->offset;
 525    else
 526       range = pCreateInfo->range;
 527    uint32_t elements = range / util_format_get_blocksize(pfmt);
 528
 529    static const VkComponentMapping components = {
 530       .r = VK_COMPONENT_SWIZZLE_R,
 531       .g = VK_COMPONENT_SWIZZLE_G,
 532       .b = VK_COMPONENT_SWIZZLE_B,
 533       .a = VK_COMPONENT_SWIZZLE_A,
 534    };
 535
 536    uint64_t iova = tu_buffer_iova(buffer) + pCreateInfo->offset;
 537
 538    memset(&view->descriptor, 0, sizeof(view->descriptor));
 539
 540    view->descriptor[0] =
 541       A6XX_TEX_CONST_0_TILE_MODE(TILE6_LINEAR) |
 542       A6XX_TEX_CONST_0_SWAP(fmt->swap) |
 543       A6XX_TEX_CONST_0_FMT(fmt->tex) |
 544       A6XX_TEX_CONST_0_MIPLVLS(0) |
 545       tu6_texswiz(&components, vfmt, VK_IMAGE_ASPECT_COLOR_BIT);
 546       COND(vk_format_is_srgb(vfmt), A6XX_TEX_CONST_0_SRGB);
 547    view->descriptor[1] =
 548       A6XX_TEX_CONST_1_WIDTH(elements & MASK(15)) |
 549       A6XX_TEX_CONST_1_HEIGHT(elements >> 15);
 550    view->descriptor[2] =
 551       A6XX_TEX_CONST_2_UNK4 |
 552       A6XX_TEX_CONST_2_UNK31;
 553    view->descriptor[4] = iova;
 554    view->descriptor[5] = iova >> 32;
 555 }
 556
 557 VkResult
 558 tu_CreateBufferView(VkDevice _device,
 559                     const VkBufferViewCreateInfo *pCreateInfo,
 560                     const VkAllocationCallbacks *pAllocator,
 561                     VkBufferView *pView)
 562 {
 563    TU_FROM_HANDLE(tu_device, device, _device);
 564    struct tu_buffer_view *view;
 565
 566    view = vk_alloc2(&device->alloc, pAllocator, sizeof(*view), 8,
 567                     VK_SYSTEM_ALLOCATION_SCOPE_OBJECT);
 568    if (!view)
 569       return vk_error(device->instance, VK_ERROR_OUT_OF_HOST_MEMORY);
 570
 571    tu_buffer_view_init(view, device, pCreateInfo);
 572
 573    *pView = tu_buffer_view_to_handle(view);
 574
 575    return VK_SUCCESS;
 576 }
 577
 578 void
 579 tu_DestroyBufferView(VkDevice _device,
 580                      VkBufferView bufferView,
 581                      const VkAllocationCallbacks *pAllocator)
 582 {
 583    TU_FROM_HANDLE(tu_device, device, _device);
 584    TU_FROM_HANDLE(tu_buffer_view, view, bufferView);
 585
 586    if (!view)
 587       return;
 588
 589    vk_free2(&device->alloc, pAllocator, view);
 590 }